<h4>Pre-Submission Checklist</h4>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="415058582" data-permission-text="Issue title is private" data-url="https://github.com/kamailio/kamailio/issues/1871" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/1871/hovercard" href="https://github.com/kamailio/kamailio/issues/1871">#1871</a></li>
</ul>
<h4>Description</h4>

<pre><code>   - TMCB_ACK_NEG_IN was called in an if branch where the initial
condition was the message to be an INVITE; this was not affecting
anything for the moment since this callback wasn't used but in case
some piece of code would have used this callback it would be called
not only for hop-by-hop ACKs but also INVITEs
</code></pre>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/1890'>https://github.com/kamailio/kamailio/pull/1890</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>tm: remove unnecessary TMCB_ACK_NEG_IN callback call</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1890/files#diff-0">src/modules/tm/t_reply.c</a>
    (8)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/1890.patch'>https://github.com/kamailio/kamailio/pull/1890.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/1890.diff'>https://github.com/kamailio/kamailio/pull/1890.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1890">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36Zd6lk2uXyOhSD4niIPnKL8uYdxv-ks5vV7mZgaJpZM4brCWb">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZTMBQTYZYroMKYkYjN65EgD0F321ks5vV7mZgaJpZM4brCWb.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"tm: remove unnecessary TMCB_ACK_NEG_IN callback call (#1890)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1890"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1890",
"url": "https://github.com/kamailio/kamailio/pull/1890",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>