<p>Hello, thank you. About the remaining two topics:</p>
<ul>
<li>regarding the ETSI standards, maybe you can add some comments later on how this module was tested against (like some hardware, vendor etc..) when you finished development</li>
<li>about the cmake file - if its only related to your local development environment, then please remove it from the pull request, it don't need to be integrated in the repository then<br>
Let us know when you've finished the implementation to follow up here.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1856#issuecomment-469011300">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36Zf8k1MBmrBnNkQRoT8VknxRKXdIAks5vS6pFgaJpZM4a-_NY">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZabEsgvi-Nky49nXS81Scc-xGhnhks5vS6pFgaJpZM4a-_NY.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@henningw in #1856: Hello, thank you. About the remaining two topics:\r\n- regarding the ETSI standards, maybe you can add some comments later on how this module was tested against (like some hardware, vendor etc..) when you finished development\r\n- about the cmake file - if its only related to your local development environment, then please remove it from the pull request, it don't need to be integrated in the repository then\r\nLet us know when you've finished the implementation to follow up here."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1856#issuecomment-469011300"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1856#issuecomment-469011300",
"url": "https://github.com/kamailio/kamailio/pull/1856#issuecomment-469011300",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>