<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>This patch set contains a bunch of improvements to the imc module. Most of the changes are backwards-compatible, but some change the semantics of individual imc commands slightly. I have tested the changes with the Zoiper client on Android and with a custom WebRTC client. The motivation behind these changes was to make the imc module a bit more consistent, predictable, and usable.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1869'>https://github.com/kamailio/kamailio/pull/1869</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Rename command "deny" to "reject"</li>
<li>Minor language fixes</li>
<li>Rename "exit" to "leave", keep backward compatiblity</li>
<li>Remove code duplication.</li>
<li>Collect chat room related strings in one place.</li>
<li>Use STR_FMT in formatted string arguments.</li>
<li>Use correct command prefix in the invite message.</li>
<li>Make behavior of "#join" when room does not exist configurable</li>
<li>Define message prefix with a macro</li>
<li>Make behavior of "#create" configurable when room already exists</li>
<li>Pass both parsed and unparsed URIs to all command handlers</li>
<li>Consistent handling of command parameters.</li>
<li>Make #create command arguments optional</li>
<li>Rename command #list to #members.</li>
<li>Cleanup in invite related messages.</li>
<li>Consistent formatting of room/user names.</li>
<li>Improved #join command handling</li>
<li>Notify user #leaving a room.</li>
<li>Make message buffer larger</li>
<li>A small fix in #join</li>
<li>Check arguments in #invite</li>
<li>Implement command #add</li>
<li>Implement command #rooms</li>
<li>Add In-Reply-To header to MESSAGEs generated in response</li>
<li>Add Supported header to all chat room MESSAGEs.</li>
<li>Report error if room owner sends #leave</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1869/files#diff-0">src/modules/imc/README</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1869/files#diff-1">src/modules/imc/doc/imc_admin.xml</a>
(62)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1869/files#diff-2">src/modules/imc/imc.c</a>
(92)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1869/files#diff-3">src/modules/imc/imc.h</a>
(8)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1869/files#diff-4">src/modules/imc/imc_cmd.c</a>
(1595)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1869/files#diff-5">src/modules/imc/imc_cmd.h</a>
(66)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1869/files#diff-6">src/modules/imc/imc_mng.c</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1869.patch'>https://github.com/kamailio/kamailio/pull/1869.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1869.diff'>https://github.com/kamailio/kamailio/pull/1869.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1869">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZVM11wRGIsyWuMcoZmHaWV2-TuvLks5vRVkTgaJpZM4bSgUz">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZfwwEuBYK2sHOekkmnONVVKrDhWFks5vRVkTgaJpZM4bSgUz.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Imc improvements (#1869)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1869"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1869",
"url": "https://github.com/kamailio/kamailio/pull/1869",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>