Hello Henning,<br>
In regards of first comment, This module is developed to provide handover<br>
interface for lawful Interception in IMS-Network(VoIP-Services) for<br>
Kamailio. Actually I am developing,yet, just as like some optimization<br>
code, add extra features and more. My implementation is based on ETSI<br>
TS133.108 and TS133.107. In this case Kamailio works just as LIG (Lawful<br>
Interception Gateway) in VoIP network and getting all data (signalling)<br>
from network and send them for LEA in specific (TLV) template.<br>
Along with of second comment, yes, of course. We could talk more about it<br>
after developing finished.<br>
As well as of third comment, i have never pushed cmake file before, It is<br>
my GUI (CLION GUI) for programming in C that i am working on with.<br>
And fourth comment, i deleted htable commit from here and make new pull<br>
request.<br>
With Best Regards. Mojtaba<br>
<br>
<br>
On Mon, Feb 25, 2019 at 1:49 PM Henning Westerholt <notifications@github.com><br>
wrote:<br>
<br>
> Thank you for the your interest in Kamailio and the module in development.<br>
> I did a quick high level look today and have a few comments:<br>
><br>
> - can you give a small description what your module actually does? :-)<br>
> - a huge part of your code is related to the asn1 functionality. Some<br>
> of this is library code that could be maybe placed elsewhere, some of them<br>
> is generated from a ASN1 definition. If you finished the development we<br>
> should discuss how to deal with this. Maybe something can be also just add<br>
> as a build dependency and don't need to be included.<br>
> - there is a cmake file inside, do you use cmake for something? In<br>
> Kamailio we use standard make for building<br>
> - you just pushed a change to the htable module, this should be a<br>
> separate pull request as its isolated from your module<br>
><br>
> —<br>
> You are receiving this because you are subscribed to this thread.<br>
> Reply to this email directly, view it on GitHub<br>
> <https://github.com/kamailio/kamailio/pull/1856#issuecomment-466956126>,<br>
> or mute the thread<br>
> <https://github.com/notifications/unsubscribe-auth/ArE2rHQoyy1mbCV-B-ZItjank6pBnl0Rks5vQ7jLgaJpZM4a-_NY><br>
> .<br>
><br>
<br>
<br>
-- <br>
--Mojtaba Esfandiari.S<br>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1856#issuecomment-466971511">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZUNgo_zgjnmbbH_UeytciQYh9W6Aks5vQ8RMgaJpZM4a-_NY">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZRFvlt_nC-6QyWJyvpC9A5nRI9obks5vQ8RMgaJpZM4a-_NY.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mojtabaesfandiari in #1856: Hello Henning,\nIn regards of first comment, This module is developed to provide handover\ninterface for lawful Interception in IMS-Network(VoIP-Services) for\nKamailio. Actually I am developing,yet, just as like some optimization\ncode, add extra features and more. My implementation is based on ETSI\nTS133.108 and TS133.107. In this case Kamailio works just as LIG (Lawful\nInterception Gateway) in VoIP network and getting all data (signalling)\nfrom network and send them for LEA in specific (TLV) template.\nAlong with of second comment, yes, of course. We could talk more about it\nafter developing finished.\nAs well as of third comment, i have never pushed cmake file before, It is\nmy GUI (CLION GUI) for programming in C that i am working on with.\nAnd fourth comment, i deleted htable commit from here and make new pull\nrequest.\nWith Best Regards. Mojtaba\n\n\nOn Mon, Feb 25, 2019 at 1:49 PM Henning Westerholt \u003cnotifications@github.com\u003e\nwrote:\n\n\u003e Thank you for the your interest in Kamailio and the module in development.\n\u003e I did a quick high level look today and have a few comments:\n\u003e\n\u003e - can you give a small description what your module actually does? :-)\n\u003e - a huge part of your code is related to the asn1 functionality. Some\n\u003e of this is library code that could be maybe placed elsewhere, some of them\n\u003e is generated from a ASN1 definition. If you finished the development we\n\u003e should discuss how to deal with this. Maybe something can be also just add\n\u003e as a build dependency and don't need to be included.\n\u003e - there is a cmake file inside, do you use cmake for something? In\n\u003e Kamailio we use standard make for building\n\u003e - you just pushed a change to the htable module, this should be a\n\u003e separate pull request as its isolated from your module\n\u003e\n\u003e —\n\u003e You are receiving this because you are subscribed to this thread.\n\u003e Reply to this email directly, view it on GitHub\n\u003e \u003chttps://github.com/kamailio/kamailio/pull/1856#issuecomment-466956126\u003e,\n\u003e or mute the thread\n\u003e \u003chttps://github.com/notifications/unsubscribe-auth/ArE2rHQoyy1mbCV-B-ZItjank6pBnl0Rks5vQ7jLgaJpZM4a-_NY\u003e\n\u003e .\n\u003e\n\n\n-- \n--Mojtaba Esfandiari.S\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1856#issuecomment-466971511"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1856#issuecomment-466971511",
"url": "https://github.com/kamailio/kamailio/pull/1856#issuecomment-466971511",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>