<div dir="auto"><div>Hello Henning,<div dir="auto"><br></div><div dir="auto">After the push I realized that I forgot to update the author. My bad.</div><div dir="auto">I wanted to revert the commit, but I didn't know if we have a preferred way of doing it.</div><div dir="auto">So, is there a guideline for reverting a commit? I will revert it and re-commit with proper credentials.</div><div dir="auto"><br></div><div dir="auto">Thanks,</div><div dir="auto">Ovidiu</div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Feb 21, 2019, 02:51 Henning Westerholt <<a href="mailto:hw@kamailio.org">hw@kamailio.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Am Mittwoch, 20. Februar 2019, 21:12:07 CET schrieb root:<br>
> Module: kamailio<br>
> Branch: master<br>
> Commit: 91b2c5da34ba7064f858b13bf0a1d27da74336d4<br>
> URL:<br>
> <a href="https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27" rel="noreferrer noreferrer" target="_blank">https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27</a><br>
> da74336d4<br>
> <br>
> Author: root <<a href="mailto:root@livepbx-nit-syd-kam-01.livepbx.com.au" target="_blank" rel="noreferrer">root@livepbx-nit-syd-kam-01.livepbx.com.au</a>><br>
> Committer: root <<a href="mailto:root@livepbx-nit-syd-kam-01.livepbx.com.au" target="_blank" rel="noreferrer">root@livepbx-nit-syd-kam-01.livepbx.com.au</a>><br>
> Date: 2019-02-21T07:11:25+11:00<br>
> <br>
> siputils: fix debug logging<br>
> <br>
> ---<br>
> <br>
> Modified: src/modules/siputils/contact_ops.c<br>
> <br>
> ---<br>
> <br>
> Diff: <br>
> <a href="https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27" rel="noreferrer noreferrer" target="_blank">https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27</a><br>
> da74336d4.diff Patch:<br>
> <a href="https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27" rel="noreferrer noreferrer" target="_blank">https://github.com/kamailio/kamailio/commit/91b2c5da34ba7064f858b13bf0a1d27</a><br>
> da74336d4.patch<br>
<br>
Hello,<br>
<br>
please add a proper User and e-mail address to your local git configuration:<br>
<br>
<a href="https://help.github.com/en/articles/setting-your-commit-email-address-in-git" rel="noreferrer noreferrer" target="_blank">https://help.github.com/en/articles/setting-your-commit-email-address-in-git</a><br>
<a href="https://help.github.com/en/articles/setting-your-username-in-git" rel="noreferrer noreferrer" target="_blank">https://help.github.com/en/articles/setting-your-username-in-git</a><br>
<br>
It is necessary to have a proper (human) author for all commits in the public <br>
repository. Please reply to this e-mail that we have it in the archives as <br>
well. <br>
<br>
Otherwise I think we should revert this commit (could be of course applied <br>
again).<br>
<br>
Best regards,<br>
<br>
Henning<br>
<br>
-- <br>
Henning Westerholt - <a href="https://skalatan.de/blog/" rel="noreferrer noreferrer" target="_blank">https://skalatan.de/blog/</a><br>
Kamailio services - <a href="https://skalatan.de/services" rel="noreferrer noreferrer" target="_blank">https://skalatan.de/services</a><br>
Kamailio security assessment - <a href="https://skalatan.de/de/assessment" rel="noreferrer noreferrer" target="_blank">https://skalatan.de/de/assessment</a><br>
<br>
_______________________________________________<br>
Kamailio (SER) - Development Mailing List<br>
<a href="mailto:sr-dev@lists.kamailio.org" target="_blank" rel="noreferrer">sr-dev@lists.kamailio.org</a><br>
<a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev" rel="noreferrer noreferrer" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
</blockquote></div></div></div>