<p>The commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/728bbc4d5b6b68a157a3528058d7a2f543f40382/hovercard" href="https://github.com/kamailio/kamailio/commit/728bbc4d5b6b68a157a3528058d7a2f543f40382"><tt>728bbc4</tt></a> does not seem right, it is setting branch expire to the dialog value, which is not correct.</p>
<p>As for commit <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/kamailio/kamailio/commit/cf70716afc9cfff4ba8ab0e75e9c6364f2874393/hovercard" href="https://github.com/kamailio/kamailio/commit/cf70716afc9cfff4ba8ab0e75e9c6364f2874393"><tt>cf70716</tt></a> -- the tps_storage_end_dialog() has a check inside to be executed only for BYE:</p>
<ul>
<li><a href="https://github.com/kamailio/kamailio/blob/master/src/modules/topos_redis/topos_redis_storage.c#L1322">https://github.com/kamailio/kamailio/blob/master/src/modules/topos_redis/topos_redis_storage.c#L1322</a></li>
</ul>
<p>Can you check if you have the same code base, give that you said you run some custom version.</p>
<p>If you have it, then maybe the issue is somewhere else, not setting properly the method id in the structure.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1849#issuecomment-463139817">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZXr4-VK0PM4SqjSRCfg-mWJBiZvEks5vM-TfgaJpZM4a3aB4">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZSecgJ106GohpKJkikZEgSKvmgK8ks5vM-TfgaJpZM4a3aB4.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1849: The commit 728bbc4 does not seem right, it is setting branch expire to the dialog value, which is not correct.\r\n\r\nAs for commit cf70716 -- the tps_storage_end_dialog() has a check inside to be executed only for BYE:\r\n\r\n  * https://github.com/kamailio/kamailio/blob/master/src/modules/topos_redis/topos_redis_storage.c#L1322\r\n\r\nCan you check if you have the same code base, give that you said you run some custom version.\r\n\r\nIf you have it, then maybe the issue is somewhere else, not setting properly the method id in the structure."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1849#issuecomment-463139817"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1849#issuecomment-463139817",
"url": "https://github.com/kamailio/kamailio/pull/1849#issuecomment-463139817",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>