<p>Looks good - thanks!</p>
<p>Would it be sensible to add a module parameter to configure the number of failed pings before a node is considered dead (defaulting to 1 to preserve current behaviour)?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1840#issuecomment-461374995">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZWKFVku5JTVNsUOl9AbRND2EFLvKks5vLAdRgaJpZM4anBLT">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZTQAwQMXCUVwHL9oBS_DCwxPx_5Aks5vLAdRgaJpZM4anBLT.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@charlesrchance in #1840: Looks good - thanks!\r\n\r\nWould it be sensible to add a module parameter to configure the number of failed pings before a node is considered dead (defaulting to 1 to preserve current behaviour)?"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1840#issuecomment-461374995"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1840#issuecomment-461374995",
"url": "https://github.com/kamailio/kamailio/pull/1840#issuecomment-461374995",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>