<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>I remember there was some discussion about adding DNS statistics, I think I remember a discussion involving <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=5746180" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ngvoice">@ngvoice</a> Carsten ?</p>
<p>This is adding a parameter to the core <code>dns_slow_query_ms</code></p>
<p>Example:</p>
<pre><code>dns_slow_query_ms=100
</code></pre>
<p>When using the internal resolver any query taking more than <code>dns_slow_query_ms</code> will be lodged as a warning :</p>
<pre><code>dns_slow_query_ms=10 (example with 10ms)
5(5960) WARNING: <core> [core/resolve.c:752]: get_record(): res_search[35][us-west-wa.sip.flowroute.com]elapsed[12ms]
5(5960) WARNING: <core> [core/resolve.c:752]: get_record(): res_search[1][ep-us-west-wa-01.flowroute.com]elapsed[12ms]
</code></pre>
<p>and a statistic counter will be incremented :</p>
<pre><code>kamcmd stats.fetch dns:slow_dns_request
{
dns.slow_dns_request: 1
}
</code></pre>
<p>I think this will be a good start to monitor the impact of slow DNS queries on Kamailio.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1824'>https://github.com/kamailio/kamailio/pull/1824</a></p>
<h4>Commit Summary</h4>
<ul>
<li>core: dns slow queries reporting</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1824/files#diff-0">src/core/cfg.lex</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1824/files#diff-1">src/core/cfg.y</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1824/files#diff-2">src/core/cfg_core.c</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1824/files#diff-3">src/core/cfg_core.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1824/files#diff-4">src/core/resolve.c</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1824/files#diff-5">src/core/resolve.h</a>
(3)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1824.patch'>https://github.com/kamailio/kamailio/pull/1824.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1824.diff'>https://github.com/kamailio/kamailio/pull/1824.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1824">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZfSVC8WZn5M9BwGCz0ZKGYbiuRuMks5vIJCngaJpZM4aYpFd">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZR8jp69GYPXETo5RlAgWaZct6CbHks5vIJCngaJpZM4aYpFd.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"core: dns slow queries reporting (#1824)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1824"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1824",
"url": "https://github.com/kamailio/kamailio/pull/1824",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>