<h4>Pre-Submission Checklist</h4>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="395537497" data-permission-text="Issue title is private" data-url="https://github.com/kamailio/kamailio/issues/1783" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/1783/hovercard" href="https://github.com/kamailio/kamailio/issues/1783">#1783</a></li>
</ul>
<h4>Description</h4>

<p>The result of this check is always false (or I think so because I always obtain 0!=8) and the function dlg_new_dialog() is never executed.</p>
<p>The function dlg_new_dialog() must be executed to save the new dialog. In other case the cnxcc module (I don know if there are more modules affected) doesn't work.</p>
<p>Can anyone review if this check is important, please?</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/1791'>https://github.com/kamailio/kamailio/pull/1791</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>dialog: The result of this check is always false and the function dlg_new_dialog() is never executed</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1791/files#diff-0">src/modules/dialog/dlg_handlers.c</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/1791.patch'>https://github.com/kamailio/kamailio/pull/1791.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/1791.diff'>https://github.com/kamailio/kamailio/pull/1791.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1791">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZeZUxftzNAqdh4WFbhcDL5abyOmEks5vA3PqgaJpZM4ZzzRe">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZRPCWvzgc7gCePOIUkQB8bTtjAPwks5vA3PqgaJpZM4ZzzRe.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"dialog: The result of this check is always false (#1791)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1791"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1791",
"url": "https://github.com/kamailio/kamailio/pull/1791",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>