<div dir="ltr">Hi,<div><br></div><div>given the fact, that we do a lot of "non-sip" related stuff with Kamailio (we are using Kamailio as a Diameter HSS, Diameter Charging-Server (OCS), Diameter Routing-Agent (DRA)), I would also vote for number (2):</div><div><br></div><div><span style="color:rgb(80,0,80)">> 2) remove the function export from the core and export one with the same</span><br></div><div><span style="color:rgb(80,0,80)">> name from the corex module</span></div><div><font color="#500050"><br></font></div><div><font color="#500050">Thanks,</font></div><div><font color="#500050">Carsten<br clear="all"></font><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature">--<br><br>Carsten Bock<br>CEO (Geschäftsführer)<br><br>ng-voice GmbH<br>Millerntorplatz 1<br>20359 Hamburg / Germany<br><br><a href="http://www.ng-voice.com" target="_blank">http://www.ng-voice.com</a><br>mailto:<a href="mailto:carsten@ng-voice.com" target="_blank">carsten@ng-voice.com</a><br><br>Office +49 40 5247593-40<br>Fax +49 40 5247593-99<br><br>Sitz der Gesellschaft: Hamburg<br>Registergericht: Amtsgericht Hamburg, HRB 120189<br>Geschäftsführer: Carsten Bock<br>Ust-ID: DE279344284<br><br>Hier finden Sie unsere handelsrechtlichen Pflichtangaben:<br><a href="http://www.ng-voice.com/imprint/" target="_blank">http://www.ng-voice.com/imprint/</a></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr">Am Mi., 19. Dez. 2018 um 12:55 Uhr schrieb YAS0 CANER <<a href="mailto:caner_yaso@hotmail.com">caner_yaso@hotmail.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div dir="ltr">
<div style="font-family:EmojiFont,Calibri,Helvetica,sans-serif,"Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;font-size:12pt;color:rgb(0,0,0)">
TmEXIT , kEXIT and corEXIT is failed <span>😊</span></div>
<div style="font-family:Calibri,Helvetica,sans-serif;font-size:12pt;color:rgb(0,0,0)">
</div>
<hr style="display:inline-block;width:98%">
<div id="gmail-m_3511166570168917619divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> sr-users <<a href="mailto:sr-users-bounces@lists.kamailio.org" target="_blank">sr-users-bounces@lists.kamailio.org</a>> on behalf of Olle E. Johansson <<a href="mailto:oej@edvina.net" target="_blank">oej@edvina.net</a>><br>
<b>Sent:</b> Wednesday, December 19, 2018 2:38 PM<br>
<b>To:</b> Daniel-Constantin Mierla<br>
<b>Cc:</b> Kamailio (SER) - Development Mailing List; Kamailio (SER) - Users Mailing List<br>
<b>Subject:</b> Re: [SR-Users] [sr-dev] RFC: updates to some core functions</font>
<div> </div>
</div>
<div class="gmail-m_3511166570168917619BodyFragment"><font size="2"><span style="font-size:11pt">
<div class="gmail-m_3511166570168917619PlainText"><br>
<br>
> On 19 Dec 2018, at 12:26, Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>> wrote:<br>
> <br>
> <br>
> On 19.12.18 09:47, Olle E. Johansson wrote:<br>
>> <br>
>>> On 19 Dec 2018, at 09:41, Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>> wrote:<br>
>>> <br>
>>> corex module was added to hold the functions that otherwise would be<br>
>>> more or less "in the core", like those that were updated to support<br>
>>> variables in the parameters, so this is the one to take the place of<br>
>>> core in regard to exporting functions.<br>
>>> <br>
>>> tmx was added because tm module became very big, but also to try to<br>
>>> separate a bit between transaction management code and some functions in<br>
>>> top of it, in the way that tmx can work only with exported api by tm, so<br>
>>> if one adds a function there doesn't get access to all internals of<br>
>>> transaction and it is safer not to mess up things there. It is more or<br>
>>> less like usrloc and registrar, usrloc does internal management of<br>
>>> location records, registrar is the interface to configuration file (but<br>
>>> there are other modules on top of usrloc, like pua_usrloc, dmq_usrloc, ...).<br>
>>> <br>
>>> kex is the one that collected some functions that use to be in kamailio<br>
>>> (or better said openser at that time) but not in ser during 2005-2008<br>
>>> and can be a module that be analyzed to see if can be merged into other<br>
>>> modules. A big chunk of it used to be related to MI commands, but as we<br>
>>> got rid of MI, might be easier now to split parts of it and relocate.<br>
>>> <br>
>> Ok, so removing kex is a good first step for the coming release.<br>
>> <br>
>> It’s really hard explaining TMX and TM for new Kamailians.<br>
> <br>
> We can add a note at the top of docs for each of these modules to refer<br>
> to the other.<br>
> <br>
> On the other hand, I do not like to have a huge module. It is not<br>
> suitable for small embedded systems. Also, there are other modules using<br>
> the tm api, so it is a common approach. The tmx is exporting mostly<br>
> functions at higher level of transaction interaction, one can build a<br>
> transaction stateful sip routing without it, only using tm.<br>
> <br>
Damn it. My campaign for exit of the x modules just died. Sad story.<br>
<br>
Thanks for all the responses!<br>
<br>
/O<br>
> Cheers,<br>
> Daniel<br>
> <br>
>> <br>
>> /O :-)<br>
>> <br>
>>> Cheers,<br>
>>> Daniel<br>
>>> <br>
>>> On 19.12.18 09:25, Olle E. Johansson wrote:<br>
>>>> Going back one step, are there any reasons to keep tmx, kex and corex modules at all?<br>
>>>> <br>
>>>> At this point in the project I think many of the functions should be merged into
<br>
>>>> the main modules and core. <br>
>>>> <br>
>>>> If I remember correctly, they exist because of a multi-brand history that is not<br>
>>>> really the case any more.<br>
>>>> <br>
>>>> /O<br>
>>>> “The campaign to remove Kamailio extensions to Kamailio”<br>
>>>> <br>
>>>> <br>
>>>>> On 19 Dec 2018, at 09:11, Henning Westerholt <<a href="mailto:hw@kamailio.org" target="_blank">hw@kamailio.org</a>> wrote:<br>
>>>>> <br>
>>>>> Am Mittwoch, 19. Dezember 2018, 09:03:26 CET schrieb Sergey Safarov:<br>
>>>>>> I prefer second way. Without any duplication.<br>
>>>>>> For old configs branches 4.4, 5.0, 5.1 is always available.<br>
>>>>> Hello,<br>
>>>>> <br>
>>>>> I would prefer also the second way, for the same reason: less duplicated <br>
>>>>> functions.<br>
>>>>> <br>
>>>>> Best regards,<br>
>>>>> <br>
>>>>> Henning<br>
>>>>> <br>
>>>>> <br>
>>>>>> ср, 19 дек. 2018 г. в 10:50, Daniel-Constantin Mierla <<a href="mailto:miconda@gmail.com" target="_blank">miconda@gmail.com</a>>:<br>
>>>>>>> Hello,<br>
>>>>>>> <br>
>>>>>>> it was brought into discussions several times in the past about core<br>
>>>>>>> functions not accepting variables in the parameters. I think it is time<br>
>>>>>>> to update them during the 5.3 release development. For few of them, I<br>
>>>>>>> added in the past some alternative function in the corex module (e.g.,<br>
>>>>>>> force_send_socket() in core and set_send_socket() in corex module).<br>
>>>>>>> <br>
>>>>>>> So, I see two options:<br>
>>>>>>> <br>
>>>>>>> 1) add a function with similar name in corex module and same behaviour<br>
>>>>>>> like the one from core<br>
>>>>>>> <br>
>>>>>>> 2) remove the function export from the core and export one with the same<br>
>>>>>>> name from the corex module<br>
>>>>>>> <br>
>>>>>>> First one will ensure that configs using the functions right now keep<br>
>>>>>>> working without any update.<br>
>>>>>>> <br>
>>>>>>> The second one will be better in long term from the point of<br>
>>>>>>> documentation (no duplicated docs), but there might be few cases that<br>
>>>>>>> would require updates in the config -- iirc, there are some functions<br>
>>>>>>> that can get special tokens in the parameters (like forward(uri:host,<br>
>>>>>>> uri:port)), they will get an equivalent with variables, but old config<br>
>>>>>>> will not be compatible.<br>
>>>>>>> <br>
>>>>>>> Obviously the reason for this email is to ask the developers and users<br>
>>>>>>> what would be the preferred way from own point of view.<br>
>>>>>>> <br>
>>>>>>> Cheers,<br>
>>>>>>> Daniel<br>
>>>>> -- <br>
>>>>> Henning Westerholt - <a href="https://skalatan.de/blog/" target="_blank">https://skalatan.de/blog/</a><br>
>>>>> Kamailio services - <a href="https://skalatan.de/services" target="_blank">https://skalatan.de/services</a><br>
>>>>> Kamailio security assessment - <a href="https://skalatan.de/de/assessment" target="_blank">
https://skalatan.de/de/assessment</a><br>
>>>>> <br>
>>>>> _______________________________________________<br>
>>>>> Kamailio (SER) - Development Mailing List<br>
>>>>> <a href="mailto:sr-dev@lists.kamailio.org" target="_blank">sr-dev@lists.kamailio.org</a><br>
>>>>> <a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
>>>> _______________________________________________<br>
>>>> Kamailio (SER) - Development Mailing List<br>
>>>> <a href="mailto:sr-dev@lists.kamailio.org" target="_blank">sr-dev@lists.kamailio.org</a><br>
>>>> <a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev</a><br>
>>> -- <br>
>>> Daniel-Constantin Mierla -- <a href="http://www.asipto.com" target="_blank">www.asipto.com</a><br>
>>> <a href="http://www.twitter.com/miconda" target="_blank">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda" target="_blank">
www.linkedin.com/in/miconda</a><br>
>>> Kamailio World Conference - May 6-8, 2019 -- <a href="http://www.kamailioworld.com" target="_blank">
www.kamailioworld.com</a><br>
>>> Kamailio Advanced Training - Mar 4-6, 2019 in Berlin; Mar 25-27, 2019, in Washington, DC, USA --
<a href="http://www.asipto.com" target="_blank">www.asipto.com</a><br>
>>> <br>
> -- <br>
> Daniel-Constantin Mierla -- <a href="http://www.asipto.com" target="_blank">www.asipto.com</a><br>
> <a href="http://www.twitter.com/miconda" target="_blank">www.twitter.com/miconda</a> -- <a href="http://www.linkedin.com/in/miconda" target="_blank">
www.linkedin.com/in/miconda</a><br>
> Kamailio World Conference - May 6-8, 2019 -- <a href="http://www.kamailioworld.com" target="_blank">
www.kamailioworld.com</a><br>
> Kamailio Advanced Training - Mar 4-6, 2019 in Berlin; Mar 25-27, 2019, in Washington, DC, USA --
<a href="http://www.asipto.com" target="_blank">www.asipto.com</a><br>
> <br>
<br>
<br>
_______________________________________________<br>
Kamailio (SER) - Users Mailing List<br>
<a href="mailto:sr-users@lists.kamailio.org" target="_blank">sr-users@lists.kamailio.org</a><br>
<a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a><br>
</div>
</span></font></div>
</div>
_______________________________________________<br>
Kamailio (SER) - Users Mailing List<br>
<a href="mailto:sr-users@lists.kamailio.org" target="_blank">sr-users@lists.kamailio.org</a><br>
<a href="https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users" rel="noreferrer" target="_blank">https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users</a><br>
</blockquote></div>