<p><b>@teotwaki</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1765#discussion_r242476737">src/core/tcp_main.c</a>:</p>
<pre style='color:#555'>> -    if (likely(local_addr)){
-               su2ip_addr(&c->rcv.dst_ip, local_addr);
-               c->rcv.dst_port=su_getport(local_addr);
-       }else if (ba){
-               c->rcv.dst_ip=ba->address;
-               c->rcv.dst_port=ba->port_no;
+       if (unlikely(ksr_tcp_accept_haproxy && state == S_CONN_ACCEPT)) {
+               ret = tcpconn_read_haproxy(c);
+
+               if (ret == -1) {
+                       LM_ERR("invalid PROXY protocol header\n");
+                       goto error;
+               } else if (ret == 1) {
+                       LM_DBG("PROXY protocol did not override IP addresses\n");
+                       goto read_ip_info;
+               }
</pre>
<p>There is an <code>LM_DBG()</code> indicating whether we received a PROXY v1 or PROXY v2 header. Do you feel that a parsing-success message is strictly required here (as opposed to a lack of parsing-failure message)?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1765#discussion_r242476737">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZbTiDqvgSeErrXDfQs1oWelMxYv4ks5u6MAGgaJpZM4ZR-BH">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZYqV8NqIqsKNmZEbEMiH3itNxD3hks5u6MAGgaJpZM4ZR-BH.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@teotwaki commented on #1765"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1765#discussion_r242476737"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1765#discussion_r242476737",
"url": "https://github.com/kamailio/kamailio/pull/1765#discussion_r242476737",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>