<p>I haven't gone into deep analysis, but the new code looks clean/well indented, exported functions have prefix, ..., so from my point of view, I am happy to merge it. Bugs can be discovered and fixed later, usually they pop up quicker when using it rather than reading code. If someone else wants to read more the code, can do it.</p>
<p>Anyhow, I would like to merge it manually (keeping you as the author), not from github UI (not even squashing), to have single commits for the latest version and per component. Once merged, you will get commit access so fixes and enhancements can be pushed directly by you.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1755#issuecomment-448002015">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZdPV1OCurZnVqB6EGWonTDUoEPkOks5u6AnpgaJpZM4ZCb-V">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZeDxV34-8wRBJjMYfTXNocmc8DCcks5u6AnpgaJpZM4ZCb-V.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1755: I haven't gone into deep analysis, but the new code looks clean/well indented, exported functions have prefix, ..., so from my point of view, I am happy to merge it. Bugs can be discovered and fixed later, usually they pop up quicker when using it rather than reading code. If someone else wants to read more the code, can do it.\r\n\r\nAnyhow, I would like to merge it manually (keeping you as the author), not from github UI (not even squashing), to have single commits for the latest version and per component. Once merged, you will get commit access so fixes and enhancements can be pushed directly by you."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1755#issuecomment-448002015"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1755#issuecomment-448002015",
"url": "https://github.com/kamailio/kamailio/pull/1755#issuecomment-448002015",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>