<p>Ok <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=184809" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/miconda">@miconda</a>, I think I learned how to do all the Github related stuff and went with the <code>#if PY_VERSION_HEX >= 0x03070000</code> style of version checking based on <a href="https://docs.python.org/3/c-api/apiabiversion.html" rel="nofollow">https://docs.python.org/3/c-api/apiabiversion.html</a></p>
<p>While this patch "fixes" the Python3.7 deprecation warnings, I don't know how the project overall likes to handle things like this.  I'm guessing that true devs would prefer to NOT litter code with <code>#if #endif</code> statements, but that's for you guys to decide.</p>
<p>Thank you for letting me try to contribute.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/1748#issuecomment-447501741">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZR2ZfMWImu_uqXcm0f6-16aIHTveks5u5CqKgaJpZM4Y8-74">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZQbdJZj4tjhYfqzpLoBTAdEPsisZks5u5CqKgaJpZM4Y8-74.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@amessina in #1748: Ok @miconda, I think I learned how to do all the Github related stuff and went with the `#if PY_VERSION_HEX \u003e= 0x03070000` style of version checking based on https://docs.python.org/3/c-api/apiabiversion.html\r\n\r\nWhile this patch \"fixes\" the Python3.7 deprecation warnings, I don't know how the project overall likes to handle things like this.  I'm guessing that true devs would prefer to NOT litter code with `#if #endif` statements, but that's for you guys to decide.\r\n\r\nThank you for letting me try to contribute."}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1748#issuecomment-447501741"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/issues/1748#issuecomment-447501741",
"url": "https://github.com/kamailio/kamailio/issues/1748#issuecomment-447501741",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>