<p><b>@linuxmaniac</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1762#discussion_r240687591">src/modules/app_ruby/Makefile</a>:</p>
<pre style='color:#555'>> @@ -30,7 +30,7 @@ ifneq (,$(findstring darwin,$(OS)))
        LIBS += -L/opt/local/lib -L$(LOCALBASE)/lib -lev
 else
        DEFS += -I$(LOCALBASE)/include -I$(SYSBASE)/include
-       LIBS += -L$(LOCALBASE)/lib -L$(SYSBASE)/lib -lruby -lpthread -ldl -lobjc
</pre>
<p>I don't know if is needed or not, I'm saying the changes need to be split. You are changing the app_ruby, those changes need to be in another commit with the proper commit message prefix</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1762#discussion_r240687591">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZRL9TqHroO2sMMeHa_RMsQTuCLKqks5u393tgaJpZM4ZNrXu">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZUIS_Nry_MMhNDEcw9JJhEPIozGUks5u393tgaJpZM4ZNrXu.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@linuxmaniac commented on #1762"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1762#discussion_r240687591"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1762#discussion_r240687591",
"url": "https://github.com/kamailio/kamailio/pull/1762#discussion_r240687591",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@linuxmaniac commented on 1762",
"sections": [
{
"text": "",
"activityTitle": "**Victor Seva**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@linuxmaniac",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1762#discussion_r240687591"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 423015918\n}"
}
],
"themeColor": "26292E"
}
]</script>