<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=770988" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/lazedo">@lazedo</a> - the PR does not have documentation for the new function.</p>
<p>Also, I wonder if makes sense to have a parameter for the function in order to set the status code of uas, now it is hardcoded to 500. It can be helpful in case of some tm callbacks (e.g., for accounting or dialog) to be able to have a specific code chosen from config.</p>
<p>Then, I am not sure if just setting the uas response code is enough overall, more or less in the context of tm callbacks being executed when transaction is destroyed. Here I need to look a bit more at what is needed from the UAS structure of tm.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1726#issuecomment-439870643">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZctSecASMKW9tOqRM8cnoUnMmBnwks5uwp32gaJpZM4YmkpZ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zc302brfPL_khXRmQ_s_ZODm4L8Pks5uwp32gaJpZM4YmkpZ.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1726: @lazedo - the PR does not have documentation for the new function.\r\n\r\nAlso, I wonder if makes sense to have a parameter for the function in order to set the status code of uas, now it is hardcoded to 500. It can be helpful in case of some tm callbacks (e.g., for accounting or dialog) to be able to have a specific code chosen from config.\r\n\r\nThen, I am not sure if just setting the uas response code is enough overall, more or less in the context of tm callbacks being executed when transaction is destroyed. Here I need to look a bit more at what is needed from the UAS structure of tm."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1726#issuecomment-439870643"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1726#issuecomment-439870643",
"url": "https://github.com/kamailio/kamailio/pull/1726#issuecomment-439870643",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] tmx: add t_drop (#1726)",
"sections": [
{
"text": "",
"activityTitle": "**Daniel-Constantin Mierla**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@miconda",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1726,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1726\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1726#issuecomment-439870643"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 412764761\n}"
}
],
"themeColor": "26292E"
}
]</script>