<p>Hi Henning, thank you for taking  some time to do the a review,  I will address all the comments shortly.</p>
<p>Yes integrating a RTP endpoint directly in Kamailio may seems strange at first.</p>
<p>I did discuss this approach 2 years ago at Kamailio World and we discussed about this year at Cluecon with Daniel and Fred, the last feedback I got was that this was interesting.</p>
<p>By doing integration with a library we can benefit from the scripting engine and probably KEMI.<br>
This does not means that everyone should run this module on a Kamailio sever acting as a load balancer, of course CPU intensive operations like resampling and encoding may be taking place on the server.</p>
<p>I think the comments in this MR are hiting ser-dev mainling list but it make sense to write an email as well.</p>
<p>Much appreciated !</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1701#issuecomment-435208289">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZduGsLgTRbv-rKbOrrDEpxCU-e1Lks5uq3VngaJpZM4YF7gV">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZdCJf50C4n7HXMuiuFRqSY5rFQ_Cks5uq3VngaJpZM4YF7gV.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jchavanton in #1701: Hi Henning, thank you for taking  some time to do the a review,  I will address all the comments shortly.\r\n\r\nYes integrating a RTP endpoint directly in Kamailio may seems strange at first.\r\n\r\nI did discuss this approach 2 years ago at Kamailio World and we discussed about this year at Cluecon with Daniel and Fred, the last feedback I got was that this was interesting.\r\n\r\nBy doing integration with a library we can benefit from the scripting engine and probably KEMI.\r\nThis does not means that everyone should run this module on a Kamailio sever acting as a load balancer, of course CPU intensive operations like resampling and encoding may be taking place on the server.\r\n\r\nI think the comments in this MR are hiting ser-dev mainling list but it make sense to write an email as well.\r\n\r\nMuch appreciated !\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1701#issuecomment-435208289"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1701#issuecomment-435208289",
"url": "https://github.com/kamailio/kamailio/pull/1701#issuecomment-435208289",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] rtp_media_server: adding module (#1701)",
"sections": [
{
"text": "",
"activityTitle": "**Julien Chavanton**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jchavanton",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1701,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1701\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1701#issuecomment-435208289"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 404207637\n}"
}
],
"themeColor": "26292E"
}
]</script>