<p>I found consufion about using the integer value of the flag when checking it.</p>
<p>acc_run_engines</p>
<pre><code> if((type==1) && (msg->flags&(e->missed_flag))) {
</code></pre>
<p>and<br>
is_eng_acc_on</p>
<pre><code> if(msg->flags & e->missed_flag) {
</code></pre>
<p>However when we reset it we use the bit position value</p>
<pre><code>reset_acc_flag( req, flags_to_reset );
#define reset_acc_flag(_rq,_flag) (resetflag((_rq), (_flag)))
</code></pre>
<p>Looking at this further</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/1673#issuecomment-429066023">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZSeUl4OCva3tDQf7inUVAC-EcwDfks5uj4xDgaJpZM4XWT31">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zd04JXsXQAunpXsnq5rGki28GlN1ks5uj4xDgaJpZM4XWT31.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jchavanton in #1673: I found consufion about using the integer value of the flag when checking it.\r\n\r\nacc_run_engines\r\n```\r\n if((type==1) \u0026\u0026 (msg-\u003eflags\u0026(e-\u003emissed_flag))) {\r\n```\r\nand \r\nis_eng_acc_on \r\n```\r\n if(msg-\u003eflags \u0026 e-\u003emissed_flag) {\r\n```\r\n\r\nHowever when we reset it we use the bit position value\r\n```\r\nreset_acc_flag( req, flags_to_reset ); \r\n#define reset_acc_flag(_rq,_flag) (resetflag((_rq), (_flag))) \r\n```\r\n\r\nLooking at this further"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1673#issuecomment-429066023"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/issues/1673#issuecomment-429066023",
"url": "https://github.com/kamailio/kamailio/issues/1673#issuecomment-429066023",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] acc: generating duplicates on missed / failed calls (#1673)",
"sections": [
{
"text": "",
"activityTitle": "**Julien Chavanton**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jchavanton",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1673,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1673\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/issues/1673#issuecomment-429066023"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 391724533\n}"
}
],
"themeColor": "26292E"
}
]</script>