<p><b>@jchavanton</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1674#discussion_r224599267">src/modules/acc/acc_logic.c</a>:</p>
<pre style='color:#555'>>      if (is_log_mc_on(req)) {
                env_set_text( ACC_MISSED, ACC_MISSED_LEN);
                acc_log_request( req );
-               flags_to_reset |= log_missed_flag;
+               flags_to_reset |= 1 << log_missed_flag;
</pre>
<p>I wonder why this was not creating more problem in the past the flags variable where containing "bit position", this is one point that the reviewer can help to confirm. (I may triple check that this is always true)</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1674#pullrequestreview-164008683">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZcPWCTbLRouMAn6Ry9-_CnycFL_dks5uj6-OgaJpZM4XYVgP">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZXtIV2ZCU9NTDLC68HRObPdmh80Eks5uj6-OgaJpZM4XYVgP.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jchavanton commented on #1674"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1674#pullrequestreview-164008683"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1674#pullrequestreview-164008683",
"url": "https://github.com/kamailio/kamailio/pull/1674#pullrequestreview-164008683",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@jchavanton commented on 1674",
"sections": [
{
"text": "",
"activityTitle": "**Julien Chavanton**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jchavanton",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1674#pullrequestreview-164008683"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 392255503\n}"
}
],
"themeColor": "26292E"
}
]</script>