<p>The filter has a regex looking for a literal '{' in the beginning of a<br>
line. Some awk implementations interpret this as a meta character, so<br>
the regex is deemed broken. Example with busybox awk (POSIX):</p>
<p><code>root@hank2:~# kamctl ps</code><br>
<code>awk: bad regex '^{.+"id"[ ]*:[ ]*[0-9]+[ ]*}$': Invalid contents of {}</code><br>
<code>root@hank2:~#</code></p>
<p>To fix this enclose the character in square brackets. This always<br>
matches for a literal '{' and is portable.</p>
<p>Signed-off-by: Sebastian Kemper <a href="mailto:sebastian_ml@gmx.net">sebastian_ml@gmx.net</a></p>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="295023966" data-permission-text="Issue title is private" data-url="https://github.com/kamailio/kamailio/issues/1429" data-hovercard-type="issue" data-hovercard-url="/kamailio/kamailio/issues/1429/hovercard" href="https://github.com/kamailio/kamailio/issues/1429">#1429</a></li>
</ul>
<h4>Description</h4>
<p>Hi all,</p>
<p>I was trying to run kamctl on OpenWrt and the regex failed. I found a (closed) issue and the remedy was to use gawk. But it's actually easy to fix in the regex and when I can run busybox awk I can't save the space which would be needed for gawk. OpenWrt is usually run on embedded so space is often an issue :)</p>
<p>Thanks for looking at this!</p>
<p>Kind regards,<br>
Seb</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/1669'>https://github.com/kamailio/kamailio/pull/1669</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>kamctl: make jsonrpc filter portable</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1669/files#diff-0">utils/kamctl/kamctl.base</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/1669.patch'>https://github.com/kamailio/kamailio/pull/1669.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/1669.diff'>https://github.com/kamailio/kamailio/pull/1669.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1669">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZdXVwETUC0rIMqdUh1BhKxTJIniRks5uijhzgaJpZM4XL8Wl">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZUuN2fU3WHm0qluDdMNwaEaeNuMKks5uijhzgaJpZM4XL8Wl.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"kamctl: make jsonrpc filter portable (#1669)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1669"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1669",
"url": "https://github.com/kamailio/kamailio/pull/1669",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "kamctl: make jsonrpc filter portable (#1669)",
"sections": [
{
"text": "",
"activityTitle": "**micmac1**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@micmac1",
"facts": [

]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "59d2875",
"value": "kamctl: make jsonrpc filter portable"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[utils/kamctl/kamctl.base](https://github.com/kamailio/kamailio/pull/1669/files#diff-0) (2 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1669,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1669\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1669"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1669.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1669.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 389006757\n}"
}
],
"themeColor": "26292E"
}
]</script>