<h4>Pre-Submission Checklist</h4>
<ul>
<li>[ X] Commit message has the format required by CONTRIBUTING guide</li>
<li>[ X] Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li>[ X] Each component has a single commit (if not, squash them into one commit)</li>
<li>[ X] No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li>[ X] New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li>[x ] Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>Operations performed in async workers can be blocking (e.g. DB inserts). Sometimes, under high load, this can lead the unix socket queues to be full, thus blocking the main workers. With this new parameter we can have the choice to open the socket pair in non blocking mode, so returning an error if the task cannot be sent to the async workers.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1654'>https://github.com/kamailio/kamailio/pull/1654</a></p>
<h4>Commit Summary</h4>
<ul>
<li>core: new parameter async_nonblock</li>
<li>async,db_mysql,db_unixodbc: return -1 and free memory if sending task to the async worker fails</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1654/files#diff-0">src/core/async_task.c</a>
(16)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1654/files#diff-1">src/core/async_task.h</a>
(1)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1654/files#diff-2">src/core/cfg.lex</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1654/files#diff-3">src/core/cfg.y</a>
(3)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1654/files#diff-4">src/modules/async/async_sleep.c</a>
(7)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1654/files#diff-5">src/modules/db_mysql/km_dbase.c</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1654/files#diff-6">src/modules/db_unixodbc/dbase.c</a>
(6)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1654.patch'>https://github.com/kamailio/kamailio/pull/1654.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1654.diff'>https://github.com/kamailio/kamailio/pull/1654.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1654">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZQzN-Ny7rONF74NPjcO8MXyCJaSAks5ufL4ZgaJpZM4W8gZI">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZSyJtR3XfYi0huPkOR8ZE_C3mTQtks5ufL4ZgaJpZM4W8gZI.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Non blocking async socket (#1654)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1654"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1654",
"url": "https://github.com/kamailio/kamailio/pull/1654",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Non blocking async socket (#1654)",
"sections": [
{
"text": "",
"activityTitle": "**Federico Cabiddu**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@grumvalski",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "762fec5",
"value": "core: new parameter async_nonblock"
},
{
"name": "bd29b46",
"value": "async,db_mysql,db_unixodbc: return -1 and free memory if sending task to the async worker fails"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/core/async_task.c](https://github.com/kamailio/kamailio/pull/1654/files#diff-0) (16 changes)"
},
{
"name": "Modified",
"value": "[src/core/async_task.h](https://github.com/kamailio/kamailio/pull/1654/files#diff-1) (1 changes)"
},
{
"name": "Modified",
"value": "[src/core/cfg.lex](https://github.com/kamailio/kamailio/pull/1654/files#diff-2) (2 changes)"
},
{
"name": "Modified",
"value": "[src/core/cfg.y](https://github.com/kamailio/kamailio/pull/1654/files#diff-3) (3 changes)"
},
{
"name": "Modified",
"value": "[src/modules/async/async_sleep.c](https://github.com/kamailio/kamailio/pull/1654/files#diff-4) (7 changes)"
},
{
"name": "Modified",
"value": "[src/modules/db_mysql/km_dbase.c](https://github.com/kamailio/kamailio/pull/1654/files#diff-5) (5 changes)"
},
{
"name": "Modified",
"value": "[src/modules/db_unixodbc/dbase.c](https://github.com/kamailio/kamailio/pull/1654/files#diff-6) (6 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1654,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1654\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1654"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1654.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1654.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 384960072\n}"
}
],
"themeColor": "26292E"
}
]</script>