<p>Thank you Armen for the patch.</p>
<p>So the current way is:<br>
$log-prefix $log-level $log-message<br>
You change it to:<br>
$log-level $log-prefix $log-message</p>
<p>I think the reasoning here was to easily distinguish Kamailio logs (with the prefix) from other application logs. But in the end this is better done with different log facilities anyway, and I think not that many people use a log prefix.</p>
<p>So this change is also fine with me. But can you please put note about this in the upgrade wiki, as it will may break some people scripts:<br>
<a href="https://www.kamailio.org/wiki/install/upgrade/stable-to-devel" rel="nofollow">https://www.kamailio.org/wiki/install/upgrade/stable-to-devel</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1610#issuecomment-409831168">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZXgl_pNiD839cKE1TPFugzYt7Hq1ks5uMqgrgaJpZM4VrPUF">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zdp8bJA6GwUuZo4VnPIsSn95HhoAks5uMqgrgaJpZM4VrPUF.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@henningw in #1610: Thank you Armen for the patch.\r\n\r\nSo the current way is:\r\n$log-prefix $log-level $log-message\r\nYou change it to:\r\n$log-level $log-prefix $log-message\r\n\r\nI think the reasoning here was to easily distinguish Kamailio logs (with the prefix) from other application logs. But in the end this is better done with different log facilities anyway, and I think not that many people use a log prefix.\r\n\r\nSo this change is also fine with me. But can you please put note about this in the upgrade wiki, as it will may break some people scripts:\r\nhttps://www.kamailio.org/wiki/install/upgrade/stable-to-devel"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1610#issuecomment-409831168"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1610#issuecomment-409831168",
"url": "https://github.com/kamailio/kamailio/pull/1610#issuecomment-409831168",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] core: print log_prefix after loglevel for more intuitive parsing (#1610)",
"sections": [
{
"text": "",
"activityTitle": "**Henning Westerholt**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@henningw",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1610,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1610\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1610#issuecomment-409831168"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 363656453\n}"
}
],
"themeColor": "26292E"
}
]</script>