<p>Tsvetomir - thank you for the clarification about the licensing. If the code in question is GPLv2, then all is fine if you keep it GPLv2 also in your license for new files. Regarding the copyright notices you choose the right approach, add the notice from the "original" file to your file if you add some parts from it.</p>
<p>Thank you Daniel for the clarification - I did not know this about the README for new modules.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1605#issuecomment-409852997">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZcRaIWIfs4N4UrTXVA7p7ArEEbAbks5uMrv2gaJpZM4VjXyg">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZbvtVh3N03xuybfCW001SZ9GWMr-ks5uMrv2gaJpZM4VjXyg.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@henningw in #1605: Tsvetomir - thank you for the clarification about the licensing. If the code in question is GPLv2, then all is fine if you keep it GPLv2 also in your license for new files. Regarding the copyright notices you choose the right approach, add the notice from the \"original\" file to your file if you add some parts from it.\r\n\r\nThank you Daniel for the clarification - I did not know this about the README for new modules. "}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1605#issuecomment-409852997"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1605#issuecomment-409852997",
"url": "https://github.com/kamailio/kamailio/pull/1605#issuecomment-409852997",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] ims_ipsec_pcscf: sec-agree implementation for IMS (#1605)",
"sections": [
{
"text": "",
"activityTitle": "**Henning Westerholt**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@henningw",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1605,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1605#issuecomment-409852997"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 361594016\n}"
}
],
"themeColor": "26292E"
}
]</script>