<p>Hi, reading the code I found it was taken from the RR header, I missed <code>record_route_preset()</code></p>
<p>This param was not absolutely necessary but I guess it is making things more clear for someone wanting to use TOPOS.<br>
And maybe simpler as well.</p>
<p>I have tested the code "back ported" only for now, but I believe this should be enough to make sure it is working fine.</p>
<p>Thanks for the review</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1596#issuecomment-406019020">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZfLgQ3ibpROehWqZy1zg6-VzkOjQks5uH3YcgaJpZM4VTjsO">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZdDwbwPWARc5s8D8Jgr2kmOOIujRks5uH3YcgaJpZM4VTjsO.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jchavanton in #1596: Hi, reading the code I found it was taken from the RR header, I missed `record_route_preset()`\r\n\r\nThis param was not absolutely necessary but I guess it is making things more clear for someone wanting to use TOPOS.\r\nAnd maybe simpler as well.\r\n\r\nI have tested the code \"back ported\" only for now, but I believe this should be enough to make sure it is working fine.\r\n\r\nThanks for the review\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1596#issuecomment-406019020"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1596#issuecomment-406019020",
"url": "https://github.com/kamailio/kamailio/pull/1596#issuecomment-406019020",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] topos: adding param contact_hostname (#1596)",
"sections": [
{
"text": "",
"activityTitle": "**Julien Chavanton**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jchavanton",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1596,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1596\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1596#issuecomment-406019020"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 357448462\n}"
}
],
"themeColor": "26292E"
}
]</script>