<p>After SSL_CTX is not only containing default settings but hash of sessions, this seems to be thread safe using a locks.</p>
<pre><code>SSL_CTX_add_session
    CRYPTO_THREAD_write_lock(ctx->lock);
    ...
    CRYPTO_THREAD_unlock(ctx->lock);
</code></pre>
<p>OpenSSL can be safely used in multi-threaded applications provided that support for the underlying OS threading API is built-in. Currently, OpenSSL supports the pthread and Windows APIs. OpenSSL can also be built without any multi-threading support, for example on platforms that don't provide any threading support or that provide a threading API that is not yet supported by OpenSSL.</p>
<p>Not sure if there could be a pitfall for forking process, better keep the default value as it is.</p>
<p>It seems another option, could be to copy only the X509_store</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1585#issuecomment-404050785">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZRonXO6BBIDpaiBMCmI0C1SQSp-eks5uFY8pgaJpZM4VH3iS">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZUDP5zFl2TNLwtqicv6xGk6hTkH5ks5uFY8pgaJpZM4VH3iS.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jchavanton in #1585: After SSL_CTX is not only containing default settings but hash of sessions, this seems to be thread safe using a locks.\r\n\r\n```\r\nSSL_CTX_add_session\r\n    CRYPTO_THREAD_write_lock(ctx-\u003elock);\r\n    ...\r\n    CRYPTO_THREAD_unlock(ctx-\u003elock);\r\n```\r\n\r\nOpenSSL can be safely used in multi-threaded applications provided that support for the underlying OS threading API is built-in. Currently, OpenSSL supports the pthread and Windows APIs. OpenSSL can also be built without any multi-threading support, for example on platforms that don't provide any threading support or that provide a threading API that is not yet supported by OpenSSL.\r\n\r\nNot sure if there could be a pitfall for forking process, better keep the default value as it is.\r\n\r\nIt seems another option, could be to copy only the X509_store "}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1585#issuecomment-404050785"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/kamailio/kamailio/pull/1585#issuecomment-404050785",
"url": "https://github.com/kamailio/kamailio/pull/1585#issuecomment-404050785",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] tls: much faster startup using shared SSL_CTX (#1585)",
"sections": [
{
"text": "",
"activityTitle": "**Julien Chavanton**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@jchavanton",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1585,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1585\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1585#issuecomment-404050785"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 354384018\n}"
}
],
"themeColor": "26292E"
}
]</script>