<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>Compiling kamailio on Linux, unless <code>RAW_SOCKS</code> is set up otherwise,<br>
should automatically enable raw sockets, according to <code>Makefile.defs</code><br>
<a href="https://github.com/kamailio/kamailio/blob/a57a96f8fea3a5f7bff068ab0ea0d4c17c15bb65/src/Makefile.defs#L97">L97</a>:</p>
<pre><code># enable raw sockets
RAW_SOCKS ?= yes
ifeq ($(RAW_SOCKS),1)
RAW_SOCKS = yes
endif
</code></pre>
<p>By all indications, if <code>RAW_SOCKS</code> is unset, set to <code>1</code>, or set to <code>yes</code><br>
before this <code>ifeq</code> statement, it will be set to <code>yes</code> after the <code>endif</code>.</p>
<p>The issue arises later on in <code>Makefile.defs</code> <a href="https://github.com/kamailio/kamailio/blob/a57a96f8fea3a5f7bff068ab0ea0d4c17c15bb65/src/Makefile.defs#L1758">L1758</a>:</p>
<pre><code>#os specific stuff
ifeq ($(OS), linux)
# by default use futexes if available
use_futex= yes
C_DEFS+=-DHAVE_GETHOSTBYNAME2 -DHAVE_UNION_SEMUN -DHAVE_SCHED_YIELD \
-DHAVE_MSG_NOSIGNAL -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_ALLOCA_H \
-DHAVE_TIMEGM -DHAVE_SCHED_SETSCHEDULER -DHAVE_IP_MREQN
ifneq ($(RAW_SOCKS), yes) ### <--- The issue ###
C_DEFS+= -DUSE_RAW_SOCKS
endif
</code></pre>
<p>Clearly, the <code>ifneq</code> should be <code>ifeq</code>.</p>
<p>This commit fixes the issue by making the above change, and <code>kamailio</code><br>
should compile on Linux - by default - with raw sockets support unless<br>
<code>RAW_SOCKS</code> is explicitly set prior to evaluation to something other<br>
than <code>yes</code> or <code>1</code>.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1564'>https://github.com/kamailio/kamailio/pull/1564</a></p>
<h4>Commit Summary</h4>
<ul>
<li>core: fix Makefile.defs error to include raw socket support</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1564/files#diff-0">src/Makefile.defs</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1564.patch'>https://github.com/kamailio/kamailio/pull/1564.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1564.diff'>https://github.com/kamailio/kamailio/pull/1564.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1564">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZbotKDbMgZ8gqQ_v5qUYtoIoK80Dks5t8Xe4gaJpZM4Um5G0">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZUQvj3zwHeELOPpCLRa39UhnGpwfks5t8Xe4gaJpZM4Um5G0.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/kamailio/kamailio/pull/1564","url":"https://github.com/kamailio/kamailio/pull/1564","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"core: fix Makefile.defs error to include raw socket support (#1564)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1564"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "core: fix Makefile.defs error to include raw socket support (#1564)",
"sections": [
{
"text": "",
"activityTitle": "**Edwin Fine**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@efine",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "7eadda8",
"value": "core: fix Makefile.defs error to include raw socket support"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/Makefile.defs](https://github.com/kamailio/kamailio/pull/1564/files#diff-0) (2 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1564,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1564\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1564"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1564.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1564.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 345739700\n}"
}
],
"themeColor": "26292E"
}</script>