<h4>Pre-Submission Checklist</h4>
<ul>
<li>[X ] Commit message has the format required by CONTRIBUTING guide</li>
<li>[ X] Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li>[ X] Each component has a single commit (if not, squash them into one commit)</li>
<li>[ X] No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li>[ X] Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> PR should be backported to stable branches</li>
<li>[ X] Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>The patch contains two fixes for sec-agree parameters handling in:</p>
<ul>
<li>module ims_registar_pcscf: ealg is read in wrong field of struct ipsec_t (was in r_alg, shoud be in r_ealg)</li>
<li>modules ims_registar_pcscf and ims_userloc_pcscf: struct ipsec_t is correctly deallocated from contact.</li>
</ul>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1561'>https://github.com/kamailio/kamailio/pull/1561</a></p>
<h4>Commit Summary</h4>
<ul>
<li>ims_registrar_pcscf: Updated security_t deallocation in sec_agree.c. Fix parsing of ealg parameter.</li>
<li>ims_usrloc_pcscf: Update comment for free_security()</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1561/files#diff-0">src/modules/ims_registrar_pcscf/sec_agree.c</a>
(17)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1561/files#diff-1">src/modules/ims_registrar_pcscf/sec_agree.h</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1561/files#diff-2">src/modules/ims_usrloc_pcscf/pcontact.c</a>
(10)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1561.patch'>https://github.com/kamailio/kamailio/pull/1561.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1561.diff'>https://github.com/kamailio/kamailio/pull/1561.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1561">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36Zd7bZy9nkFf6gWZnUkd9VRRh1ruTks5t76CbgaJpZM4UkOWi">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZTaKX58ggAFEOQsJvw8f8bxKEUUyks5t76CbgaJpZM4UkOWi.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/kamailio/kamailio/pull/1561","url":"https://github.com/kamailio/kamailio/pull/1561","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Proper deallocation for the ipsec parameters in contact for IMS PCSCF modules (#1561)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1561"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Proper deallocation for the ipsec parameters in contact for IMS PCSCF modules (#1561)",
"sections": [
{
"text": "",
"activityTitle": "**Tsvetomir Dimitrov**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@tdimitrov",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "2a0bef4",
"value": "ims_registrar_pcscf: Updated security_t deallocation in sec_agree.c. Fix parsing of ealg parameter."
},
{
"name": "18f7771",
"value": "ims_usrloc_pcscf: Update comment for free_security()"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/modules/ims_registrar_pcscf/sec_agree.c](https://github.com/kamailio/kamailio/pull/1561/files#diff-0) (17 changes)"
},
{
"name": "Modified",
"value": "[src/modules/ims_registrar_pcscf/sec_agree.h](https://github.com/kamailio/kamailio/pull/1561/files#diff-1) (2 changes)"
},
{
"name": "Modified",
"value": "[src/modules/ims_usrloc_pcscf/pcontact.c](https://github.com/kamailio/kamailio/pull/1561/files#diff-2) (10 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1561,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1561\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1561"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1561.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1561.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 345040290\n}"
}
],
"themeColor": "26292E"
}</script>