<p>Ok  I'll do the pull request etc.<br>
Please forgive my unfamiliarity with kamailio patch standards...am in process of learning.</p>
<p>Below is from modules/ims_charging/ro_session_hash.h function, I've just indicated patch changes as   "+"</p>
<p>static inline void unlink_unsafe_ro_session(struct ro_session_entry *ro_session_entry, struct ro_session *ro_session) {</p>
<ul>
<li>
<p>if ((ro_session->next == 0x00) &&</p>
</li>
<li>
<pre><code>  (ro_session->prev == 0x00) &&
</code></pre>
</li>
<li>
<pre><code>   (ro_session != ro_session_entry->first) )
</code></pre>
</li>
<li>
<p>{</p>
</li>
<li>
<pre><code>  return;
</code></pre>
</li>
<li>
<p>}</p>
<p>if (ro_session->next)<br>
ro_session->next->prev = ro_session->prev;<br>
else<br>
ro_session_entry->last = ro_session->prev;<br>
if (ro_session->prev)<br>
ro_session->prev->next = ro_session->next;<br>
else<br>
ro_session_entry->first = ro_session->next;</p>
<p>ro_session->next = ro_session->prev = 0;</p>
<p>counter_add(ims_charging_cnts_h.active_ro_sessions, -1);</p>
<p>return;<br>
}</p>
</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/1549#issuecomment-395427334">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZZUsvP5ThLbsZeQxur8qXc5CgLpVks5t6S_EgaJpZM4UQYDY">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZZyJTKvH7mJLm-aFzU3ZqRJZBGCRks5t6S_EgaJpZM4UQYDY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/kamailio/kamailio/issues/1549#issuecomment-395427334","url":"https://github.com/kamailio/kamailio/issues/1549#issuecomment-395427334","name":"View Issue"},"description":"View this Issue on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@thulasizwe-n in #1549: Ok  I'll do the pull request etc.\r\nPlease forgive my unfamiliarity with kamailio patch standards...am in process of learning.\r\n\r\nBelow is from modules/ims_charging/ro_session_hash.h function, I've just indicated patch changes as   \"+\"\r\n\r\nstatic inline void unlink_unsafe_ro_session(struct ro_session_entry *ro_session_entry, struct ro_session *ro_session) {\r\n+    if ((ro_session-\u003enext == 0x00) \u0026\u0026   \r\n+       (ro_session-\u003eprev == 0x00) \u0026\u0026\r\n+        (ro_session != ro_session_entry-\u003efirst) )\r\n+    {\r\n+       return;\r\n+  }\r\n\r\n    if (ro_session-\u003enext)\r\n        ro_session-\u003enext-\u003eprev = ro_session-\u003eprev;\r\n    else\r\n        ro_session_entry-\u003elast = ro_session-\u003eprev;\r\n    if (ro_session-\u003eprev)\r\n        ro_session-\u003eprev-\u003enext = ro_session-\u003enext;\r\n    else\r\n        ro_session_entry-\u003efirst = ro_session-\u003enext;\r\n\r\n    ro_session-\u003enext = ro_session-\u003eprev = 0;\r\n\r\n    counter_add(ims_charging_cnts_h.active_ro_sessions, -1);\r\n\r\n    return;\r\n}\r\n"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1549#issuecomment-395427334"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [kamailio/kamailio] ims_charging unlink_unsafe_ro_session (#1549)",
"sections": [
{
"text": "",
"activityTitle": "**thulasizwe-n**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@thulasizwe-n",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1549,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close issue",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1549\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/issues/1549#issuecomment-395427334"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 339837144\n}"
}
],
"themeColor": "26292E"
}</script>