<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Tested changes locally against Version 5.1.0</li>
<li class="task-list-item"><input type="checkbox" id="" disabled="" class="task-list-item-checkbox" checked=""> Related to issue <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="238634046" data-permission-text="Issue title is private" data-url="https://github.com/kamailio/kamailio/issues/1168" href="https://github.com/kamailio/kamailio/issues/1168">#1168</a> (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>The ims_isc module cannot cope with the fact that asynchronous Response from HSS (Diameter SAA message) is received as "FAILURE_ROUTE". ims_isc module erroneously assumes, it is an answer from the AS. Change: added a "firstflag", which makes a difference between first call (SAA from HSS) and subsequent call (FAILURE ROUTE from AS).</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1538'>https://github.com/kamailio/kamailio/pull/1538</a></p>
<h4>Commit Summary</h4>
<ul>
<li>ims_isc: initial fix of issue #1168</li>
<li>ims_isc: implement regexec for isc_checker_find() for wildcarded PSIs</li>
<li>ims_isc: fix: use null terminated strings for regex functions</li>
<li>ims_isc: delete regexec for wildcarded PSIs from isc_checker_find()</li>
<li>ims_isc: remove KCCVICT tagging</li>
<li>Merge branch 'devel_rewi_psi' into bugfix_issue_1168</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1538/files#diff-0">src/modules/ims_isc/ims_isc_mod.c</a>
(9)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1538/files#diff-1">src/modules/ims_isc/isc.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1538/files#diff-2">src/modules/ims_isc/isc.h</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1538.patch'>https://github.com/kamailio/kamailio/pull/1538.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1538.diff'>https://github.com/kamailio/kamailio/pull/1538.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1538">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZbQALRDodU0-2_Bu3Smjkbdbo-Itks5t0_y2gaJpZM4UIgAy">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zenw5XExv5vdfBPcTmPWbDyHHmPwks5t0_y2gaJpZM4UIgAy.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/kamailio/kamailio/pull/1538","url":"https://github.com/kamailio/kamailio/pull/1538","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Bugfix issue 1168 - Unregistered Terminating Services (PSI) Configured at HSS (#1538)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1538"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Bugfix issue 1168 - Unregistered Terminating Services (PSI) Configured at HSS (#1538)",
"sections": [
{
"text": "",
"activityTitle": "**Christoph VALENTIN**",
"activityImage": "https://avatars3.githubusercontent.com/u/29600456?s=160\u0026v=4",
"activitySubtitle": "@christoph-v",
"facts": [
]
},
{
"title": "Commit Summary",
"facts": [
{
"name": "ac301fe",
"value": "ims_isc: initial fix of issue #1168"
},
{
"name": "ea2f997",
"value": "ims_isc: implement regexec for isc_checker_find() for wildcarded PSIs"
},
{
"name": "9972565",
"value": "ims_isc: fix: use null terminated strings for regex functions"
},
{
"name": "8f7416f",
"value": "ims_isc: delete regexec for wildcarded PSIs from isc_checker_find()"
},
{
"name": "64c7727",
"value": "ims_isc: remove KCCVICT tagging"
},
{
"name": "7ca2e58",
"value": "Merge branch 'devel_rewi_psi' into bugfix_issue_1168"
}
]
},
{
"title": "File Changes",
"facts": [
{
"name": "Modified",
"value": "[src/modules/ims_isc/ims_isc_mod.c](https://github.com/kamailio/kamailio/pull/1538/files#diff-0) (9 changes)"
},
{
"name": "Modified",
"value": "[src/modules/ims_isc/isc.c](https://github.com/kamailio/kamailio/pull/1538/files#diff-1) (4 changes)"
},
{
"name": "Modified",
"value": "[src/modules/ims_isc/isc.h](https://github.com/kamailio/kamailio/pull/1538/files#diff-2) (2 changes)"
}
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1538,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1538\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1538"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1538.patch"
}
],
"@type": "OpenUri",
"name": "View patch"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1538.diff"
}
],
"@type": "OpenUri",
"name": "View diff"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 337772594\n}"
}
],
"themeColor": "26292E"
}</script>