<p>As described in the pull template: " Each component has a single commit (if not, squash them into one commit)" - so yes this is generally good.<br>
It makes review easier, we also don't want to include your local development "history" in our master branch.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1538#issuecomment-391111667">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZatC7A8elZi-PHaSfbcn8DZ7mRy-ks5t1GZcgaJpZM4UIgAy">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36ZaNBOM8kFLI73gxz3BATYiRvrsiJks5t1GZcgaJpZM4UIgAy.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/kamailio/kamailio/pull/1538#issuecomment-391111667","url":"https://github.com/kamailio/kamailio/pull/1538#issuecomment-391111667","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@henningw in #1538: As described in the pull template: \" Each component has a single commit (if not, squash them into one commit)\" - so yes this is generally good.\r\nIt makes review easier, we also don't want to include your local development \"history\" in our master branch. "}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1538#issuecomment-391111667"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "Re: [kamailio/kamailio] Bugfix issue 1168 - Unregistered Terminating Services (PSI) Configured at HSS (#1538)",
"sections": [
{
"text": "",
"activityTitle": "**Henning Westerholt**",
"activityImage": "https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png",
"activitySubtitle": "@henningw",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"issueId\": 1538,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"kamailio/kamailio\",\n\"pullRequestId\": 1538\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1538#issuecomment-391111667"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 337772594\n}"
}
],
"themeColor": "26292E"
}</script>