<p><b>@lbalaceanu</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1529#discussion_r189856101">src/modules/p_usrloc/ul_db_watch.c</a>:</p>
<pre style='color:#555'>> @@ -149,6 +152,25 @@ void check_dbs(unsigned int ticks, void *param){
        lock_release(list_lock);
 }
 
+void check_master_db(int dbm_write_default) {
+       if(mdb_availability_control) {
+               if(mdb.write.dbh){
</pre>
<p>Is it necessary to close the connection each time when verifying it?</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1529#discussion_r189861601">src/modules/p_usrloc/doc/p_usrloc_admin.xml</a>:</p>
<pre style='color:#555'>> @@ -677,6 +677,26 @@ modparam("usrloc", "db_update_as_insert", 1)
 ...
 modparam("p_usrloc", "default_db_url", "mysql://ser:ser@localhost/ser")
 ...
+</programlisting>
</pre>
<p>Since this is related to write_on_master_db, please move this documentation under the write_on_master_db parameter.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1529#discussion_r189875563">src/modules/p_usrloc/ul_db.c</a>:</p>
<pre style='color:#555'>> @@ -102,13 +102,16 @@ int ul_db_child_init(void) {
        if(ul_db_child_locnr_init() == -1) return -1;
        
        LM_INFO("location number is %d\n", max_loc_nr);
-       if(db_master_write){
+        lock_get(&write_on_master_db_shared->lock);
</pre>
<p>Check whether in ul_db_init() you need to acquire locks at all. It seems like this function is called one time only, before any fork is done, so most probably no synchronisation is needed. Same for lock release.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-122112955">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZUi_LLThUoeeLT_UcDUorFPVlqD9ks5t0__0gaJpZM4T9WXa">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zc55fz0HoLNsfe7m8Nhr7hbnppPKks5t0__0gaJpZM4T9WXa.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-122112955","url":"https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-122112955","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lbalaceanu commented on #1529"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-122112955"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "@lbalaceanu commented on 1529",
"sections": [
{
"text": "",
"activityTitle": "**Lucian Balaceanu**",
"activityImage": "https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png",
"activitySubtitle": "@lbalaceanu",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-122112955"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 334849498\n}"
}
],
"themeColor": "26292E"
}</script>