<p><b>@lbalaceanu</b> commented on this pull request.</p>

<p>I will continue the review tomorrow.</p><hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1529#discussion_r189632000">src/modules/p_usrloc/p_usrloc_mod.c</a>:</p>
<pre style='color:#555'>> @@ -307,6 +309,13 @@ static int mod_init(void)
        }
 #endif
 
+       if((write_on_master_db_shared = shm_malloc(sizeof(dbm_write_t))) == NULL) {
</pre>
<p>Make sure to shm_free this allocated memory.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1529#discussion_r189635637">src/modules/p_usrloc/p_usrloc_mod.h</a>:</p>
<pre style='color:#555'>> @@ -123,5 +123,11 @@ extern int connection_expires;
 extern int alg_location;
 
 extern int  max_loc_nr;
+typedef struct dbm_write {
</pre>
<p>Structure name must be a noun.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1529#discussion_r189637930">src/modules/p_usrloc/ul_db_watch.c</a>:</p>
<pre style='color:#555'>> @@ -96,7 +96,10 @@ void check_dbs(unsigned int ticks, void *param){
        ul_db_handle_list_t * tmp2, * new_element;
        int found;
        int i;
-       
+
+       if(mdb_availability_control) {
</pre>
<p>mdb_availability_control is also checked inside check_master_db() function.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-121849062">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36Zf1Eh74fUhoQdK-5OaVju4zNVbjRks5t0vMrgaJpZM4T9WXa">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zf3u_tDh4yj5wgwhzjM94-s6xDkZks5t0vMrgaJpZM4T9WXa.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","potentialAction":{"@type":"ViewAction","target":"https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-121849062","url":"https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-121849062","name":"View Pull Request"},"description":"View this Pull Request on GitHub","publisher":{"@type":"Organization","name":"GitHub","url":"https://github.com"}}</script>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lbalaceanu commented on #1529"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-121849062"}}}</script>
<script type="application/ld+json">{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "37567f93-e2a7-4e2a-ad37-a9160fc62647",
"title": "@lbalaceanu commented on 1529",
"sections": [
{
"text": "I will continue the review tomorrow.",
"activityTitle": "**Lucian Balaceanu**",
"activityImage": "https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png",
"activitySubtitle": "@lbalaceanu",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/kamailio/kamailio/pull/1529#pullrequestreview-121849062"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 334849498\n}"
}
],
"themeColor": "26292E"
}</script>