<ul>
<li>I understand the reasoning behind the pre-processor defines now, if this is an existing patter used in other projects its probably a good idea to use it in our code as well.</li>
<li>As for the private key loading procedure related to the fork(), I know this issue from other modules, good that you take care of that.<br>
I will have a closer look to the code, and comment in-line there.</li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1484#issuecomment-374495868">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZfWKarIUSTlUPvC1sNjsv2T3rmIyks5tgKlNgaJpZM4SsL5H">mute the thread</a>.<img src="https://github.com/notifications/beacon/AF36Zffz9dZc13ceRGyywK2wV-kd1hQ9ks5tgKlNgaJpZM4SsL5H.gif" height="1" width="1" alt="" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1484#issuecomment-374495868"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@henningw in #1484: * I understand the reasoning behind the pre-processor defines now, if this is an existing patter used in other projects its probably a good idea to use it in our code as well.\r\n* As for the private key loading procedure related to the fork(), I know this issue from other modules, good that you take care of that.\r\nI will have a closer look to the code, and comment in-line there."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1484#issuecomment-374495868"}}}</script>