<p><b>@hdikme</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/kamailio/kamailio/pull/1442#discussion_r169303694">src/modules/rtpengine/rtpengine.c</a>:</p>
<pre style='color:#555'>> @@ -1675,6 +1677,20 @@ static int build_rtpp_socks() {
LM_WARN("Failed enable set MTU discovery socket option\n");
#endif
+ if((0 <= control_cmd_tos) && (control_cmd_tos < 256)) {
+ unsigned char tos = control_cmd_tos;
+ if (pnode->rn_umode == 6) {
+ setsockopt(rtpp_socks[pnode->idx], IPPROTO_IPV6,
+ IPV6_TCLASS, &tos,
+ sizeof(tos));
</pre>
<p>I have seen in the following link (<a href="https://notes.shichao.io/unp/ch7/" rel="nofollow">https://notes.shichao.io/unp/ch7/</a>) that the data type for IP_TOS is "int". Therefore i also changed for IPv4, otherwise your comment was clear. Anyway, i have changed it based on your review again, thank you for your time.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1442#discussion_r169303694">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZSB040kV8B-yR3yIgIM0yGRDFPU5ks5tWrs_gaJpZM4SHAf9">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZX5L8XvXyMsFuRy_s0D5i8UW_fDHks5tWrs_gaJpZM4SHAf9.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1442#discussion_r169303694"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@hdikme commented on #1442"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1442#discussion_r169303694"}}}</script>