<p>I tried proposed changes.<br>
in ps_match_dialog_state_from_body<br>
there is a loop:<br>
while(node != NULL) {<br>
....<br>
why do we need there one more while loop?<br>
What actually happens:<br>
.....<br>
if(strcmp(tmp_state, vstate)!=0) { // here we come only once, when matching first dialog<br>
...</p>
<p>all later dialogs are iterating in the second while loop.</p>
<p>as for me  this part of code</p>
<pre><code>+ do {
+                       if(node->next != NULL && node->next->name != NULL
+                                       && xmlStrcmp(node->name, node->next->name) == 0) {
+                               node = node->next;
+                               break;
+                       }
+                       node = node->next;
+               } while(node != NULL);
</code></pre>
<p>should look like:</p>
<pre><code>                 node = node->next;
</code></pre>
<p>maybe that checks for NULL are also necessary, but not while do-while.</p>
<p>General question - is there a way to propose changes in your custom branch?</p>
<p>thanks for your help!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/1427#issuecomment-364987310">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZQvJ6Z081MhTVWQemMn0w1y0r55eks5tUGzlgaJpZM4R5QB3">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZZt5ERkPQB5nRbZxR4v04RNnewl7ks5tUGzlgaJpZM4R5QB3.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/issues/1427#issuecomment-364987310"></link>
  <meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@vance-od in #1427: I tried proposed changes. \r\nin ps_match_dialog_state_from_body\r\nthere is a loop:\r\nwhile(node != NULL) {\r\n....\r\nwhy do we need there one more while loop? \r\nWhat actually happens:\r\n.....\r\nif(strcmp(tmp_state, vstate)!=0) { // here we come only once, when matching first dialog\r\n...\r\n\r\nall later dialogs are iterating in the second while loop. \r\n\r\nas for me  this part of code\r\n```\r\n+ do {\r\n+\t\t\tif(node-\u003enext != NULL \u0026\u0026 node-\u003enext-\u003ename != NULL\r\n+\t\t\t\t\t\u0026\u0026 xmlStrcmp(node-\u003ename, node-\u003enext-\u003ename) == 0) {\r\n+\t\t\t\tnode = node-\u003enext;\r\n+\t\t\t\tbreak;\r\n+\t\t\t}\r\n+\t\t\tnode = node-\u003enext;\r\n+\t\t} while(node != NULL);\r\n```\r\n\r\nshould look like:\r\n```\r\n\t\t\tnode = node-\u003enext;\r\n```\r\nmaybe that checks for NULL are also necessary, but not while do-while.\r\n\r\nGeneral question - is there a way to propose changes in your custom branch? \r\n\r\nthanks for your help!"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1427#issuecomment-364987310"}}}</script>