<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Tested changes locally</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>This change provides support in <code>ndb_redis</code> for a scenario where the Redis server is part of a cluster <em>and</em> the IP addresses of the nodes are either not known in advance or are subject to change (for example in case the cluster sees new nodes being added).<br>
Before this change <code>ndb_redis</code> supports the <code>cluster</code> option, so that after a <code>MOVED</code> response from a node <code>ndb_redis</code> will perform again the same query but towards the redirection target. The caveat is that <code>ndb_redis</code> must know in advance which IP addresses will be used by the nodes.<br>
A<code>MOVED</code> response is in the form <code>-MOVED 1234 1.2.3.4:6379.</code>, indicating the hash for the request and the redirection target IP address and port.<br>
Every node in the cluster must have a modparam entry with <code>name=IP_ADDRESS:PORT;addr=IP_ADDRESS;port=PORT</code>.<br>
With the changes in this PR, ndb_redis doesn't need to have in advance the list of nodes but it can "discover" them at runtime.<br>
There is a caveat to this solution: while defining the nodes in advance allows to define also <code>pass</code>, <code>sock</code> and <code>db</code>, this is currently not supported (and default values are used). If this change will be accepted though, we could add a module parameter to define <code>pass</code>, <code>sock</code> and <code>db</code> for the dynamic nodes.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1436'>https://github.com/kamailio/kamailio/pull/1436</a></p>
<h4>Commit Summary</h4>
<ul>
<li>ndb_redis: dynamic discovery of nodes</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1436/files#diff-0">src/modules/ndb_redis/doc/ndb_redis_admin.xml</a>
(30)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1436/files#diff-1">src/modules/ndb_redis/ndb_redis_mod.c</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1436/files#diff-2">src/modules/ndb_redis/redis_client.c</a>
(53)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1436.patch'>https://github.com/kamailio/kamailio/pull/1436.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1436.diff'>https://github.com/kamailio/kamailio/pull/1436.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1436">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZadelbMCD3Mmm4R_dVDzW7w-tNpSks5tT07xgaJpZM4SBfpY">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZYNFlAg3ei-4vJr_UY_i7ItFoKAGks5tT07xgaJpZM4SBfpY.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1436"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"ndb_redis: dynamic discovery of nodes (#1436)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1436"}}}</script>