<h3>Description</h3>
<p>When processing a multipart INVITE using the rtpengine module. The rtpengine_offer configuration function (called with default arguments) is stripping all bodies except the application/sdp MIME type body.</p>
<h3>Troubleshooting</h3>
<h4>Reproduction</h4>
<p>A client is sending an INVITE through a kamailio proxy paired with a rtpengine.</p>
<pre><code>Client Proxy Server
x INVITE (SDP) x x x
x qqqqqqqqqqqqqqqqqqqqqqqqqq> x x x
x 100 Trying x x x
x <qqqqqqqqqqqqqqqqqqqqqqqqqq x x x
x x x INVITE (SDP) x
x x x qqqqqqqqqqqqqqqqqqqqqqqqqq> x
x x x 100 Trying x
x x x <qqqqqqqqqqqqqqqqqqqqqqqqqq x
x x x x
x x x x
x x x x
x x x x
x x x x
x x x x
x x x 200 OK (SDP) x
x x x <qqqqqqqqqqqqqqqqqqqqqqqqqq x
x 200 OK (SDP) x x x
x <qqqqqqqqqqqqqqqqqqqqqqqqqq x x x
</code></pre>
<p>The INVITE contains a application/sdp body and one or several other bodies of different MIME types.</p>
<p>When the INVITE is going out of the proxy, all other bodies except the application/sdp MIME are filtered out.</p>
<p>While The INVITE "Content-Type" header is still fixed to :<br>
<code>Content-Type: multipart/mixed;boundary="[boundary value]"</code></p>
<p>RTP Engine receives only the SDP body on its socket and is rewritting well the RTP ports.</p>
<h4>Debugging Data</h4>
<pre><code>(paste your debugging data here)
</code></pre>
<h4>Log Messages</h4>
<pre><code>(paste your log messages here)
</code></pre>
<h4>SIP Traffic</h4>
<pre><code>(paste your sip traffic here)
</code></pre>
<h3>Possible Solutions</h3>
<p>This issue has been introduced by the following commit : <a href="https://github.com/kamailio/kamailio/commit/36cb753441a78bd13ded119cd468f32623f09fbf" class="commit-link"><tt>36cb753</tt></a>.</p>
<p>rtpengine.c :</p>
<div class="highlight highlight-source-diff"><pre><span class="pl-mdr">@@ -3328,6 +3328,7 @@</span> rtpengine_offer_answer(struct sip_msg *msg, const char *flags, int op, int more)
str body, newbody;
struct lump *anchor;
pv_value_t pv_val;
+ str cur_body = {0, 0};
dict = rtpp_function_call_ok(&bencbuf, msg, op, flags, &body);
if (!dict)
@@ -3357,7 +3358,12 @@ rtpengine_offer_answer(struct sip_msg *msg, const char *flags, int op, int more)
pkg_free(newbody.s);
} else {
- anchor = del_lump(msg, body.s - msg->buf, body.len, 0);
+ /* get the body from the message as body ptr may have changed */
+ cur_body.len = 0;
+ cur_body.s = get_body(msg);
+ cur_body.len = msg->buf + msg->len - cur_body.s;
+
+ anchor = del_lump(msg, cur_body.s - msg->buf, cur_body.len, 0);
if (!anchor) {
LM_ERR("del_lump failed\n");
goto error_free;</pre></div>
<p>If this commit is removed, the previous behavior is restored.</p>
<p>This commit fixes a segfault: "rtpengine: fixed segfault when using read_sdp_pv", so it appears to me that this may be useful.</p>
<p>For, now I am not seeing why this is happening.</p>
<h3>Additional Information</h3>
<ul>
<li><strong>Kamailio Version</strong> - output of <code>kamailio -v</code></li>
</ul>
<p>seen on:</p>
<pre><code>version: kamailio 5.1.0 (x86_64/linux)
flags: STATS: Off, EXTRA_DEBUG, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled on 15:29:43 Feb 8 2018 with gcc 4.8.4
</code></pre>
<p>but I think that the same behavior will be seen on master.</p>
<ul>
<li><strong>Operating System</strong>:</li>
</ul>
<pre><code>(paste your output here)
</code></pre>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/issues/1434">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZYrWkE8k1pWb8oVXfWQIKFgRMJuDks5tSw71gaJpZM4R-glf">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZWnYoEawy2GPQWLzXEmuEN_oPAJvks5tSw71gaJpZM4R-glf.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/issues/1434"></link>
<meta itemprop="name" content="View Issue"></meta>
</div>
<meta itemprop="description" content="View this Issue on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"rtpengine: rtpengine_offer is stripping all INVITE multipart bodies except application/sdp (#1434)"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1434"}}}</script>