<p>3 days for the entire PR (and 2 days from last comment) is not a long period of time, specially if people are traveling or vacation.</p>
<p>Before merging, if it is not a module you developed, then ask again like:</p>
<pre><code>If no further comments in 3 days, then I will merge ...
</code></pre>
<p>This is a generic remark, not saying that this PR should be reverted. But overall, it's not advisable to rush and merge specially on big changes.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1417#issuecomment-362236904">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZQCqthQyf-M_s9qlGDX2_eCSUdIDks5tQZ5WgaJpZM4RxGM7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZbDbBLvesckdlyOji-cQ8XxzYEDLks5tQZ5WgaJpZM4RxGM7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1417#issuecomment-362236904"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1417: 3 days for the entire PR (and 2 days from last comment) is not a long period of time, specially if people are traveling or vacation.\r\n\r\nBefore merging, if it is not a module you developed, then ask again like:\r\n\r\n```\r\nIf no further comments in 3 days, then I will merge ...\r\n```\r\n\r\nThis is a generic remark, not saying that this PR should be reverted. But overall, it's not advisable to rush and merge specially on big changes."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1417#issuecomment-362236904"}}}</script>