<p>To me, adding a separate function for an extra two params is bloating the code.</p>
<p>The final two params are a direct passthrough, anyway. So your function simply becomes:</p>
<pre><code>int _api_pres_refresh_watchers(str *pres, str *event, int type, str *file_uri, str *filename)
{
        return pres_refresh_watchers(pres, event, type, file_uri, filename);
}
</code></pre>
<p>Compared with:</p>
<pre><code>int _api_pres_refresh_watchers(str *pres, str *event, int type)
{
        return pres_refresh_watchers(pres, event, type, NULL, NULL);
}

int _api_pres_refresh_watchers_file(str *pres, str *event, int type, str *file_uri, str *filename)
{
        return pres_refresh_watchers(pres, event, type, file_uri, filename);
}
</code></pre>
<p>Plus you consider others' needs in future and not just your own right now.</p>
<p>Just my opinion - perhaps others think differently.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1417#issuecomment-361693961">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZWxiibBBLCimIooPO7H5KEGclJP5ks5tP2OLgaJpZM4RxGM7">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36Ze7WWLLpdlhrzLFDqkmzBr8mGkJDks5tP2OLgaJpZM4RxGM7.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1417#issuecomment-361693961"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@charlesrchance in #1417: To me, adding a separate function for an extra two params is bloating the code.\r\n\r\nThe final two params are a direct passthrough, anyway. So your function simply becomes:\r\n\r\n```\r\nint _api_pres_refresh_watchers(str *pres, str *event, int type, str *file_uri, str *filename)\r\n{\r\n\treturn pres_refresh_watchers(pres, event, type, file_uri, filename);\r\n}\r\n```\r\n\r\nCompared with:\r\n\r\n```\r\nint _api_pres_refresh_watchers(str *pres, str *event, int type)\r\n{\r\n\treturn pres_refresh_watchers(pres, event, type, NULL, NULL);\r\n}\r\n\r\nint _api_pres_refresh_watchers_file(str *pres, str *event, int type, str *file_uri, str *filename)\r\n{\r\n\treturn pres_refresh_watchers(pres, event, type, file_uri, filename);\r\n}\r\n```\r\n\r\nPlus you consider others' needs in future and not just your own right now.\r\n\r\nJust my opinion - perhaps others think differently."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1417#issuecomment-361693961"}}}</script>