<p>Looking at the code I think it is better to change the prototype of:</p>
<pre><code>str _json_extract_field(struct json_object *json_obj, char *json_name)
</code></pre>
<p>to:</p>
<pre><code>int _json_extract_field(struct json_object *json_obj, char *json_name, str *val)
</code></pre>
<p>Now it returns a variable declared on the stack, which could work with recent compilers, being returned by value. <code>str</code> itself is not a large structure, but returning structure values is not recommended in C, code analyzers complain about (same for passing a structure value as parameter -- it is recommended to use pointers).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/commit/5fe86186e2856ce5039c0133e1f53b62df2be485#commitcomment-27188215">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZWMaPPg_EVr4phs83b8wojXODJ1Xks5tPhjrgaJpZM4RxNAe">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZS4p9kt1AGA_joBeNWawxYI2hWPiks5tPhjrgaJpZM4RxNAe.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/commit/5fe86186e2856ce5039c0133e1f53b62df2be485#commitcomment-27188215"></link>
  <meta itemprop="name" content="View Commit"></meta>
</div>
<meta itemprop="description" content="View this Commit on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda on 5fe8618: Looking at the code I think it is better to change the prototype of:\r\n\r\n```\r\nstr _json_extract_field(struct json_object *json_obj, char *json_name)\r\n```\r\n\r\nto:\r\n\r\n```\r\nint _json_extract_field(struct json_object *json_obj, char *json_name, str *val)\r\n```\r\n\r\nNow it returns a variable declared on the stack, which could work with recent compilers, being returned by value. `str` itself is not a large structure, but returning structure values is not recommended in C, code analyzers complain about (same for passing a structure value as parameter -- it is recommended to use pointers)."}],"action":{"name":"View Commit","url":"https://github.com/kamailio/kamailio/commit/5fe86186e2856ce5039c0133e1f53b62df2be485#commitcomment-27188215"}}}</script>