<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Tested changes locally</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>Hi there!<br>
So my case, and why I did not use the existing code:</p>
<ul>
<li>incoming INVITE to a user with 2 records in usrloc (1st - UDP, 2nd - TLS)</li>
<li>some time before lookup, TLS connect of 2nd device is closed, but usrloc record still exists (it going to be removed in the next iteration of timer)</li>
<li>after lookup(location) - 2 branches are created</li>
<li>send to 1st - UDP succeed</li>
<li>send to 2nd - TLS failed. And here is my headache.<br>
-- I want to send push notification to this device<br>
-- I set t_on_branch_failure<br>
-- if I try failure_exec_mode=1 - I get control, and I am able to send push, but I need to wait until fr_timer fire (I wanted not to wait, and send immediately)</li>
</ul>
<p>The idea of changes:</p>
<ul>
<li>usrloc -> get_urecord: if t_contact has tcpcon_id & connection is not alive => mark record as expired</li>
<li>as a result, in the registrar, while lookup, this contact will fail VALID_CONTACT - and will not be returned to the scriptwriter.</li>
</ul>
<p>All of this is wrapped by handle_lost_tcp parameter (that is 0 by default), so changes are extending of handle_lost_tcp parameter of usrloc. Checked doc for usrloc, and seems to me that current description of this parameter should be untouched.</p>
<p>Marked as expired contact will be removed by timer as usual.</p>
<p>Open for discussion, and thanks in advance.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1365'>https://github.com/kamailio/kamailio/pull/1365</a></p>
<h4>Commit Summary</h4>
<ul>
<li>pua_reginfo: use outbound proxy for PUBLISHes</li>
<li>pua_reginfo: correct docs</li>
<li>Merge branch 'master' of https://github.com/kamailio/kamailio</li>
<li>usrloc: extend handle_lost_tcp use for get_urecord</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1365/files#diff-0">src/modules/usrloc/udomain.c</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1365/files#diff-1">src/modules/usrloc/urecord.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1365/files#diff-2">src/modules/usrloc/urecord.h</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1365.patch'>https://github.com/kamailio/kamailio/pull/1365.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1365.diff'>https://github.com/kamailio/kamailio/pull/1365.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1365">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZRVahrqToofQkWiFhBo_bAli1-lYks5s_5omgaJpZM4RAQAR">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36Za2lWy2NtwJ5tia81WwJCEd_a3h4ks5s_5omgaJpZM4RAQAR.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1365"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"usrloc: extend handle_lost_tcp use for get_urecord (#1365)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1365"}}}</script>