<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li>[X ] PR should be backported to stable branches</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Tested changes locally</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>This fixes mtree to be able to contain strings with character<br>
values larger than 0x80. Previously this would not work because<br>
the str.s[i] is 'char' and when cast to 'unsigned int' it would<br>
be first sign extended for maximum range (on systems where 'char'<br>
defaults to signed). E.g. on x86_64 system:<br>
(unsigned int)(char)0x80 = 4294967168</p>
<p>The >=MT_CHAR_TABLE_SIZE test would filter any string containing<br>
these characters out as invalid.</p>
<p>Code is fixed to cast _mt_char_table index to 'unsigned char'<br>
always so index is within range always. The new redundant checks<br>
against MT_CHAR_TABLE_SIZE are removed, and the result is stored<br>
to local variable (and used from it) to improve code readability.</p>
<p>The error message in mt_add_to_tree() is harmonized with the other<br>
messages to show the full string with a problem.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/1343'>https://github.com/kamailio/kamailio/pull/1343</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>mtree: fix handling of character values >= 0x80</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1343/files#diff-0">src/modules/mtree/mtree.c</a>
    (132)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/1343.patch'>https://github.com/kamailio/kamailio/pull/1343.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/1343.diff'>https://github.com/kamailio/kamailio/pull/1343.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1343">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZWR3bvIQ6PLew693sEPYWPESgzGMks5s7RutgaJpZM4QunLt">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZZ8MkgNY2RbduXDVDzmsUqyjKIzIks5s7RutgaJpZM4QunLt.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1343"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"mtree: fix handling of character values \u003e= 0x80 (#1343)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1343"}}}</script>