<p><b>@miconda</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/kamailio/kamailio/pull/1321#discussion_r152752415">src/modules/cfg_rpc/cfg_rpc.c</a>:</p>
<pre style='color:#555'>> +    str     group, var;
+       void    *val;
+       unsigned int    val_type;
+       int     ret, n;
+       unsigned int    *group_id;
+
+       n = rpc->scan(c, "SS", &group, &var);
+       /*  2: both group and variable name are present
+        * -1: only group is present, print all variables in the group */
+       if(n<2) {
+               if (n == -1) {
+                       var.s = NULL;
+                       var.len = 0;
+               }
+               else return;
+       }
</pre>
<p>I think that the right way is to read with optional specifier <code>*</code>:</p>
<pre><code>n = rpc->scan(c, "S*S", &group, &var);
</code></pre>
<p>The n is two if both were read or 1 if only group is read.</p>
<p>When n is -1, there can be other errors.</p>
<p>Otherwise, the patch is useful, thanks!</p>
<p>Can you do a new patch based on what I suggested? It can be a follow up of this one, we can squash from the web when merging.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1321#pullrequestreview-78659969">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZWIWmBcAnfbkJczSJIHyGkTMVo8Zks5s5TsogaJpZM4QkVmD">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZfHpDE3V0ZbxPlWg-TpCnYkgGkfgks5s5TsogaJpZM4QkVmD.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1321#pullrequestreview-78659969"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda commented on #1321"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1321#pullrequestreview-78659969"}}}</script>