<p>using ""%" HEX HEX" mechanism for escaping from RFC 2396</p>
<h4>Pre-Submission Checklist</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> PR should be backported to stable branches</li>
<li class="task-list-item"><input checked="" class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Tested changes locally</li>
<li class="task-list-item"><input class="task-list-item-checkbox" disabled="" id="" type="checkbox"> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>
<p>I consider it non breaking because with the existing a field containing an ASCII vertical bar '|' would break the separator count and result in broken CDRs, etc. in this case changing the default behavior is probably recommended, someone could abuse this flaw.</p>
<p>Test: consider the following message, the '|' character in the call-id will break the accounting event.</p>
<pre><code>INVITE sip:+11231234567@127.0.0.101 SIP/2.0
Via: SIP/2.0/UDP 1.1.69.51:5070;rport;branch=z9hG4bKPjpM.BvWCQzoS0BJ7TgnuLF9YtmHQTlDgd
Max-Forwards: 70
Call-ID: fG8qa5Xc-iNDLhIAnuLZP|njL1sojRRD
</code></pre>
<p>With the encoding it is replaced with '%7C', no modifications should be required to systems processing the ACC events since different behavior will only take place when there is an invalid ACC event:</p>
<pre><code>cat /var/log/acc/acc_129.log
INVITE|upDPn89PCIq7SLTssEGoLoSbC-jDRnfj||fG8qa5Xc-iNDLhIAnuLZP%7CnjL1sojRRD.|403|Forbidden
</code></pre>
<p>Extra comments:<br>
I corrected the documentation on the command 'flatstore.rotate', since it was not working, but this one is 'flatstore.k_rotate'</p>
<p>If I understand correctly this module was never migrated from SER to Kamailio completely ...<br>
This change may be the only important one for operation, so I am not proposing any extra refactoring.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/kamailio/kamailio/pull/1262'>https://github.com/kamailio/kamailio/pull/1262</a></p>
<h4>Commit Summary</h4>
<ul>
<li>db_flatstore: encode delimiter param</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1262/files#diff-0">src/modules/db_flatstore/db_flatstore.c</a>
(5)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1262/files#diff-1">src/modules/db_flatstore/doc/db_flatstore.xml</a>
(14)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1262/files#diff-2">src/modules/db_flatstore/doc/db_flatstore_params.xml</a>
(11)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1262/files#diff-3">src/modules/db_flatstore/km_flatstore.c</a>
(15)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/kamailio/kamailio/pull/1262/files#diff-4">src/modules/db_flatstore/km_flatstore.h</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/kamailio/kamailio/pull/1262.patch'>https://github.com/kamailio/kamailio/pull/1262.patch</a></li>
<li><a href='https://github.com/kamailio/kamailio/pull/1262.diff'>https://github.com/kamailio/kamailio/pull/1262.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1262">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZUohpUnFY92SZ4ELpmaNTobaHiOnks5so6kwgaJpZM4Pt1gx">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZYKIAFNhmulhH95qvnf2FalPT6Tiks5so6kwgaJpZM4Pt1gx.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1262"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"db_flatstore: encode delimiter param (#1262)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1262"}}}</script>