<p>I never used the function and I am not sure about its role/where is useful.</p>
<p>However, the current behaviour is correct if the received is added as header parameter -- enclosing it in quotes is ok there. Without enclosing it, there can be <code>received=uri;transport=xyz</code>, so transport becomes another parameter of the header, no longer part of received value.</p>
<p>Then: adding <code>received="uri;transport=xyz"</code> to URI in Contact is indeed invalid, but also removing the quotes is not ok. The transport becomes parameter to URI, not part of received parameter. In this case, the <code>=</code> has to be escaped.</p>
<p>But again, wonder when this is useful and if escaping is fixing it overall or breaks it even more so other parts need also patches.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1203#issuecomment-320767494">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZW-BQOibtFNlK0Ab8k5XfXuhzBnZks5sV29tgaJpZM4OsJJ4">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZWsLuN55uWsGKC0Hf6LZxP5JLOW2ks5sV29tgaJpZM4OsJJ4.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1203#issuecomment-320767494"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1203: I never used the function and I am not sure about its role/where is useful.\r\n\r\nHowever, the current behaviour is correct if the received is added as header parameter -- enclosing it in quotes is ok there. Without enclosing it, there can be `received=uri;transport=xyz`, so transport becomes another parameter of the header, no longer part of received value.\r\n\r\nThen: adding `received=\"uri;transport=xyz\"` to URI in Contact is indeed invalid, but also removing the quotes is not ok. The transport becomes parameter to URI, not part of received parameter. In this case, the `=` has to be escaped.\r\n\r\nBut again, wonder when this is useful and if escaping is fixing it overall or breaks it even more so other parts need also patches."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1203#issuecomment-320767494"}}}</script>