<h4>Pre-Submission Checklist</h4>



<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" checked="" disabled=""> Commit message has the format required by CONTRIBUTING guide</li>
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" checked="" disabled=""> Commits are split per component (core, individual modules, libs, utils, ...)</li>
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" checked="" disabled=""> Each component has a single commit (if not, squash them into one commit)</li>
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" checked="" disabled=""> No commits to README files for modules (changes must be done to docbook files<br>
in <code>doc/</code> subfolder, the README file is autogenerated)</li>
</ul>
<h4>Type Of Change</h4>
<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" checked="" disabled=""> Small bug fix (non-breaking change which fixes an issue)</li>
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" disabled=""> New feature (non-breaking change which adds new functionality)</li>
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" disabled=""> Breaking change (fix or feature that would change existing functionality)</li>
</ul>
<h4>Checklist:</h4>

<ul class="contains-task-list">
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" disabled=""> PR should be backported to stable branches</li>
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" checked="" disabled=""> Tested changes locally</li>
<li class="task-list-item"><input type="checkbox" class="task-list-item-checkbox" disabled=""> Related to issue #XXXX (replace XXXX with an open issue number)</li>
</ul>
<h4>Description</h4>

<p>Fix the following issues found by Coverity:<br>
<a href="https://github.com/kamailio/kamailio/commit/3c86d68620fad108248ecc6eb8712ea2154e1dd4" class="commit-link"><tt>3c86d68</tt></a> fixes defect <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916961&defectInstanceId=6138921&mergedDefectId=85605">85605</a><br>
<a href="https://github.com/kamailio/kamailio/commit/7f603ec324734decb45a2d01dc5ed5678d0fe702" class="commit-link"><tt>7f603ec</tt></a> fixes defect <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916961&defectInstanceId=6138739&mergedDefectId=86015">86015</a><br>
<a href="https://github.com/kamailio/kamailio/commit/2772f094b04414e8e6c22d76f6b365c177a0a619" class="commit-link"><tt>2772f09</tt></a> fixes defects <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916966&defectInstanceId=6138583&mergedDefectId=85807">85807</a> and <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916966&defectInstanceId=6138536&mergedDefectId=85651">85651</a><br>
<a href="https://github.com/kamailio/kamailio/commit/d8fdcb3f163d0b484268edfcb093b2df0b1a4daf" class="commit-link"><tt>d8fdcb3</tt></a> fixes defects <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916953&defectInstanceId=6138609&mergedDefectId=153773">153773</a>, <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916953&defectInstanceId=6138914&mergedDefectId=85749">85749</a> and <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916953&defectInstanceId=6138916&mergedDefectId=85702">85702</a><br>
<a href="https://github.com/kamailio/kamailio/commit/3a9365f09947e435f5c8f085147a5503252234b9" class="commit-link"><tt>3a9365f</tt></a> fixes defects <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916951&defectInstanceId=6138441&mergedDefectId=85541">85541</a> and <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916951&defectInstanceId=6138446&mergedDefectId=85543">85543</a><br>
<a href="https://github.com/kamailio/kamailio/commit/dbafb5acbf0189f68eac856ad01ef9f20b3474a0" class="commit-link"><tt>dbafb5a</tt></a> fixes defect <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916961&defectInstanceId=6138438&mergedDefectId=85484">85484</a><br>
<a href="https://github.com/kamailio/kamailio/commit/535eb886031213cd8283e1f444efa44ec5f86f80" class="commit-link"><tt>535eb88</tt></a> fixes defect <a href="https://scan8.coverity.com/reports.htm#v32382/p10993/fileInstanceId=17916969&defectInstanceId=6138778&mergedDefectId=155203">155203</a></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/kamailio/kamailio/pull/1199'>https://github.com/kamailio/kamailio/pull/1199</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>carrierroute: avoid out-of-bounds access when resetting opts</li>
  <li>carrierroute: check pointer before dereferencing it</li>
  <li>carrieroute: remove logically dead code</li>
  <li>carrierroute: avoid comparing size_t types with negative values</li>
  <li>carrierroute: check return value for fseek</li>
  <li>carrierroute: avoid truncating value returned by fgetc</li>
  <li>carrierroute: avoid ovverruning a fixed sized buffer</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1199/files#diff-0">src/modules/carrierroute/cr_config.c</a>
    (125)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1199/files#diff-1">src/modules/carrierroute/cr_db.c</a>
    (6)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1199/files#diff-2">src/modules/carrierroute/cr_fifo.c</a>
    (11)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1199/files#diff-3">src/modules/carrierroute/cr_func.c</a>
    (14)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/kamailio/kamailio/pull/1199/files#diff-4">src/modules/carrierroute/parser_carrierroute.c</a>
    (13)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/kamailio/kamailio/pull/1199.patch'>https://github.com/kamailio/kamailio/pull/1199.patch</a></li>
  <li><a href='https://github.com/kamailio/kamailio/pull/1199.diff'>https://github.com/kamailio/kamailio/pull/1199.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/kamailio/kamailio/pull/1199">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AF36ZXnGUcznRWA7a7T_9NxP4Zd33sIeks5sTuEZgaJpZM4OpYy5">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AF36ZUGDwYDcZv8D4WgegItkIihqBd_lks5sTuEZgaJpZM4OpYy5.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/kamailio/kamailio/pull/1199"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fix coverity issues in carrierroute module (#1199)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1199"}}}</script>