[sr-dev] Make some commands in kamailio rtpengine module asynchronous

[Aditya Gupta]

Hey!

I've raised a PR<https://github.com/kamailio/kamailio/pull/3286> against the master. It has passed all the build checks successfully. I'm looking forward to someone's code review.

Thank you.
________________________________
From: Henning Westerholt <hw at gilawa.com>
Sent: Monday, November 28, 2022 3:09:20 PM
To: Aditya Gupta <aditya.gupta at alumni.iiit.ac.in>; Kamailio (SER) - Development Mailing List <sr-dev at lists.kamailio.org>
Subject: RE: Make some commands in kamailio rtpengine module asynchronous


Hello,



as mentioned, there are people using rtpengine with larger installations (like some racks of rtpengine).



But we are of course always open for improvements of our code base. ??



If there are some changes that are needed in rtpengine daemon code as well, it probably needs to be raised in their issue tracker later on. But for this topic, they need to comment on that.



Regarding pull-requests for Kamailio, they should be done against development (master) branch in github. After creating the PR somebody of our developer team will have a look and review it. Usually there are some comments or adaptions necessary before merging the code into your repository.



Looking forward to your PR,



Henning



--

Henning Westerholt – https://skalatan.de/blog/

Kamailio services – https://gilawa.com<https://gilawa.com/>



From: Aditya Gupta <aditya.gupta at alumni.iiit.ac.in>
Sent: Monday, November 28, 2022 10:15 AM
To: Henning Westerholt <hw at gilawa.com>; Kamailio (SER) - Development Mailing List <sr-dev at lists.kamailio.org>
Subject: Re: Make some commands in kamailio rtpengine module asynchronous



We have 2 rtpengines in production and thousands of calls coming in. Few of them get timed out because they don't get processed in time by rtpengine. Simply by making 3 commands; offer, answer and delete. It can help us a lot with this.



I think I've understood what needs to be done and, in a day, or two I'll raise a PR with the changes for rtpengine module.

After that I guess there are some changes that needs to be done in sipwise/rtpengine media servers which seems complicated at this point.

I'm hoping for your support in improving my PR for now. Against which branch should I raise my PR??



Thank you

________________________________

From: Henning Westerholt <hw at gilawa.com<mailto:hw at gilawa.com>>
Sent: Monday, November 28, 2022 1:47:00 PM
To: Kamailio (SER) - Development Mailing List <sr-dev at lists.kamailio.org<mailto:sr-dev at lists.kamailio.org>>
Cc: Aditya Gupta <aditya.gupta at alumni.iiit.ac.in<mailto:aditya.gupta at alumni.iiit.ac.in>>
Subject: RE: Make some commands in kamailio rtpengine module asynchronous



Hello,



what is the motivation behind this? Are you seeing performance issues in a production environment that could not solved e.g., by adding some more rtpengine resources?



Regarding implementation, you could also have a look for example at the http_async_client module, which might be a bit more easy to understand regarding the async implementation in Kamailio.



Cheers,



Henning



--

Henning Westerholt – https://skalatan.de/blog/

Kamailio services – https://gilawa.com<https://gilawa.com/>



From: sr-dev <sr-dev-bounces at lists.kamailio.org<mailto:sr-dev-bounces at lists.kamailio.org>> On Behalf Of Aditya Gupta
Sent: Thursday, November 24, 2022 2:47 PM
To: sr-dev at lists.kamailio.org<mailto:sr-dev at lists.kamailio.org>
Subject: [sr-dev] Make some commands in kamailio rtpengine module asynchronous



Hello!

We needed some commands in rtpengine module to be asynchronous that is offer, answer and delete. I needed help for this.



Firstly, I went through the evapi module to understand how asynchronous commands were implemented by suspending request/responses and then by continuing. But I couldn't see anywhere where the suspended commands were being continued.



Thank you.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.kamailio.org/pipermail/sr-dev/attachments/20221128/b1333ae4/attachment-0001.htm>