<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.18.3">
</HEAD>
<BODY>
Hi,<BR>
<BR>
I'd like to jump in because I too have some needs/patches wrt the dialog module. We are also using dialog for billing.<BR>
<BR>
1/ About your patches :<BR>
> - in case "tight matching" fails (when using the Record-Route-Parameter<BR>
> for in-dialog requests), try to find the dialog based on the<BR>
> SIP-Elements in the message<BR>
<BR>
I think this is already mode 1 in 1.4 ?<BR>
<BR>
> - i've moved the loading of dialogs to the first child (rather than<BR>
> during the initialization of the module)<BR>
<BR>
May I ask what is your goal there ?<BR>
<BR>
> - i'll execute the create_dlg-callbacks when loading from database at<BR>
> startup. We do billing based on the dialog module, so we need the<BR>
> callbacks, when a dialog terminates... (and the callbacks should also be<BR>
> executed, if the proxy was restarted in the meanwhile ;-)<BR>
<BR>
I am VERY interested in your create_dlg-callbacks when loading from DB stuff !<BR>
As we do billing from dialog too, I was planning on getting to code something lalong those lines myself.<BR>
Also, I wondered about loading dialogs with other sockets than the local one in case the proxy who created a dialog died meanwhile, have you thought about this ?<BR>
<BR>
2/ I try to use is_in_profile() to determine if requests (ACK, etc...) are for an existing dialog in the script. For replies, it works fine, but for requests, the dialog callback creating the current_dlg is called only during t_relay. So I have a patch that adds a callback in pre script / request to create the dialog there. It means is_in_profile() can now be used from the request route to check if an ACk, a re-INVITE, etc... belongs to an existing dialog. It does not work for CANCELs.<BR>
<BR>
3/ I use 1.4 now, but I have patches for 1.3 (not ported yet ...) that (quoting from memory) :<BR>
. handles REQBYE properly when dialog is in DELETED state<BR>
. adds an extra_info column in the dialog from an avp (I think this one is now obsolete)<BR>
. move deleted dialogs to an other "archive" table instead of deleting them<BR>
<BR>
4/ I have partial patches that were aimed at :<BR>
. saving the dialogs earlier in DB, as soon as the INVITE is received<BR>
. adding a new state to the state_machine, RINGING<BR>
<BR>
<BR>
Please comment on this too <IMG SRC="cid:1221578611.9080.15.camel@anice.longphone.fr" ALIGN="middle" ALT=":-)" BORDER="0"><BR>
I do not want to hijack the thread, but I felt relevant to inject here my own tweaks, maybe we can do something more structured all together ? <IMG SRC="cid:1221578611.9080.15.camel@anice.longphone.fr" ALIGN="middle" ALT=":-)" BORDER="0"><BR>
<BR>
Regards,<BR>
<TABLE CELLSPACING="0" CELLPADDING="0" WIDTH="100%">
<TR>
<TD>
<BR>
<B><FONT SIZE="2"><FONT COLOR="#808080">Jérôme Martin </FONT></FONT></B><B><FONT SIZE="2"><FONT COLOR="#bebebe">| </FONT></FONT></B><B><FONT SIZE="2"><FONT COLOR="#99cc00">LongPhone</FONT></FONT></B><BR>
<B><FONT SIZE="2"><FONT COLOR="#808080">Responsable Architecture Réseau</FONT></FONT></B><BR>
<FONT SIZE="2"><FONT COLOR="#bebebe">122, rue la Boetie | 75008 Paris </FONT></FONT><BR>
<FONT SIZE="2"><FONT COLOR="#bebebe">Tel : +33 (0)1 56 26 28 44</FONT></FONT><BR>
<FONT SIZE="2"><FONT COLOR="#bebebe">Fax : +33 (0)1 56 26 28 45</FONT></FONT><BR>
<FONT COLOR="#c0c0c0">Mail :</FONT><FONT COLOR="#99cc00"> </FONT><FONT COLOR="#99cc00"><B><FONT SIZE="2">jmartin</FONT></B></FONT><FONT SIZE="2"><FONT COLOR="#bebebe">@longphone.fr</FONT></FONT><BR>
<FONT COLOR="#c0c0c0">Web :</FONT><FONT COLOR="#99cc00"> <A HREF="http://www.longphone.com">www.longphone.com</A></FONT><BR>
<BR>
<BR>
</TD>
</TR>
</TABLE>
</BODY>
</HTML>