[Kamailio-Devel] SF.net SVN: openser:[5764] trunk

[Daniel-Constantin Mierla]

On 03/26/2009 04:32 PM, Juha Heinanen wrote:
> Daniel-Constantin Mierla writes:
>
>  > I fail to see the relation between moving some code from modules in core 
>  > with your need to build average statistics. The code included in core 
>  > now was moved from snmpstats to core, that code doing the parsing of 
>  > /proc/net/* files, which are not even portable across OSes. Did I 
>  > understand wrong?
>
> i just tried to say that if sr stats implementation allows implementing
> stats on more that one counter, it will encourage more module modules to
> provide stats and if stats are used by many modules, it makes sense to
> place the implementation in core so that it is as easy to use as
> possible without a need to bind other modules.
>   
even now the statistics API is in core (no bind of other modules 
required). But implementations belong to modules. It is what we did wit 
pseudo-varibles, te API is in core the implementation is in modules, 
however, you can get access to all PVs as you wish from any module you want.

Anyhow, this is still same K statistics API, it is not an enhancement. 
It is code that reads system's /proc/net/tcp and proc/net/udp files and 
make parsed output available to snmpstats and ratelimit modules. Before 
the code was in snmpstats module only, so it is just a move of code from 
a module to core. Nothing really to do with K Statistics API.

Cheers,
Daniel

-- 
Daniel-Constantin Mierla
SIP Router Masterclass - Kamailio (OpenSER) Training
http://www.asipto.com/index.php/sip-router-masterclass/