[OpenSER-Devel] SF.net SVN: openser: [4331] trunk

[Bogdan-Andrei Iancu]

Hi Henning,

Henning Westerholt wrote:
> On Friday 06 June 2008, Anca Vamanu wrote:
>   
>> Revision: 4331
>>           http://openser.svn.sourceforge.net/openser/?rev=4331&view=rev
>> Author:   anca_vamanu
>> Date:     2008-06-06 07:36:01 -0700 (Fri, 06 Jun 2008)
>>
>> Log Message:
>> -----------
>> -  uploaded new modules that implements generic string translations based
>> on matching and replacement rules. It can be used to manipulate R-URI or a
>> PV and to translated to a new format/value.
>>     
>
> Hi Anca,
>
> thank you for providing this! We using a somewhat similar module for emergency 
> call handling here, but this is much more generic i think. :-)
>   

As Anca said, this module was written by one of our former intern - 
Ancuta Onofrei - somewhere last year.
> Please allow me a few comments about some small issues i've found.
>
> 1. Documentation
>
> Can you provide some example database contents that does some easy 
> transformations? Just to get an idea how one can write own rules.
> Additional it would be great if you could run a spellchecker on the text. :-)
>   
I have on my TODO to add to the docs some DB samples - I guess it will 
be for the next week.
Spell check done ;)
> 2. Code - regexp
> Are there any special reasons that you've included a special regular 
> expression library in the module? Are there any issues with the posix regexp 
> support we're using in the core at the moment?
shared mem and speed reasons - see the parallel thread.
>  
> Have you done any modification to this version of the lib? If so, you need to 
> state this in order to fulfil the licence of the code. Otherwise its fine 
> from the licence POV.
>   
Fixed.
> 3. Code - DB API
> The error message in init_db_data(void) is not up to date, the script has now 
> a new name. Even better would be if you just could use the 
> db_check_table_version() function, which does all the error logging for you.
>   
fixed - thanks for point it out.
> You define a function called str_to_shm there. Why do you zero terminate the 
> str data type here? If this is not necessary, you could consider using the 
> shm_str_dup function in ut.h.
>   
I will check if the null terminator is really necessary.

Regards,
Bogdan