[OpenSER-Devel] [ openser-Bugs-1862701 ] Makefile.defs sets incorrect processor -mtune for AMD64

[SourceForge.net]

Bugs item #1862701, was opened at 2008-01-02 20:56
Message generated for change (Settings changed) made by henningw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1862701&group_id=139143

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: core
Group: ver 1.3.x
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Bob Atkins (bobatkins)
Assigned to: Henning Westerholt (henningw)
Summary: Makefile.defs sets incorrect processor -mtune for AMD64

Initial Comment:
Compile failed when attempting to build on a Solaris 10 x86 amd64:

gcc  -O9 -funroll-loops  -Wcast-align  -Wall   -minline-all-stringops -falign-loops -ftree-vectorize -mtune=prescott -Wold-style-definition -Wmissing-field-initializers  -m64 -I/opt/include -I/opt/include/mysql    -DNAME='"openser"' -DVERSION='"1.3.0-tls"' -DARCH='"i386"' -DOS='"solaris"' -DCOMPILER='"gcc 4.2.2"' -D__CPU_i386 -D__OS_solaris -D__SMP_no -DCFG_DIR='"/opt/openser-1.3.0-tls/etc/openser/"' -DPKG_MALLOC -DSHM_MEM  -DSHM_MMAP -DUSE_IPV6 -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DSTATISTICS -DCHANGEABLE_DEBUG_LEVEL -DF_MALLOC  -DUSE_TLS -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024  -DHAVE_GETIPNODEBYNAME -DHAVE_SYS_SOCKIO_H -DHAVE_SCHED_YIELD -DHAVE_ALLOCA_H -DUSE_SIGACTION -D_POSIX_PTHREAD_SEMANTICS -DHAVE_DEVPOLL -DHAVE_SELECT -I/opt/ssl/include -I/opt/include -c action.c -o action.o
action.c:1: error: CPU you selected does not support x86-64 instruction set
make: *** [action.o] Error 1

Turns out that buried on the compile options is:

-mtune=prescott



----------------------------------------------------------------------

>Comment By: Henning Westerholt (henningw)
Date: 2008-04-29 11:26

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hello Bob,

i've just applied (with some delay..) your patch. I ommited the '-m64'
option for now, as i don't want to change the default binaries for all 64
bit gcc executable. Is this strictly necessary for solaris?

Please reopen this bug if this causes problems for you.

Cheers,

Henning

----------------------------------------------------------------------

Comment By: Henning Westerholt (henningw)
Date: 2008-01-03 09:36

Message:
Logged In: YES 
user_id=337916
Originator: NO

Hello Bob,

thank you for your patch. The 'prescot' option is set because the sun
architecture is not detected correctly, and therefore the i386 gcc options
are used. 

I'll review and probably apply your patch later.

Cheers,

Henning

----------------------------------------------------------------------

Comment By: Bob Atkins (bobatkins)
Date: 2008-01-02 21:00

Message:
Logged In: YES 
user_id=655552
Originator: YES

Makefile.defs now corrected to properly determine AMD processor type and
set -m64 and -march=opteron compile options correctly. See attached patch.

Attached patch also includes enhancement to turn off the '-g' debugging
symbols option by setting 'NODEBUGSYM=1' for make. By default '-g' will be
included as a compiler option to continue existing Makefile behavior. To
turn off debugging symbols set NODEBUGSYM=1
File Added: Makefile.defs.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=743020&aid=1862701&group_id=139143